src/objects-inl.h - Issue 2430273007: [runtime] Object.create(null) creates a slow object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 2430273007: [runtime] Object.create(null) creates a slow object (Closed)

Patch Set: adding tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 3ce3bdbd4999c52a46fd48aa9156cec92676ce16..5a09819f7ae6abc28a9b2a6320630a8c9c2be129 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -7575,7 +7575,7 @@ void JSReceiver::initialize_properties() {

bool JSReceiver::HasFastProperties() {

- DCHECK(properties()->IsDictionary() == map()->is_dictionary_map());

+ DCHECK_EQ(properties()->IsDictionary(), map()->is_dictionary_map());

return !properties()->IsDictionary();

}