Remove the redundant layout update from WebSurroundingText::textContent

Remove the redundant layout update from WebSurroundingText::textContent

The only usages of WebSurroundingText are in ContentDetector::FindContentRange and
RenderFrameImpl::OnTextSurroundingSelectionRequest, neither of which performs any
DOM or style change between the initialization of WebSurroundingText and the call
sites of textContent. Hence, the layout update in WebSurroundingText::textContent
is redundant and removed by this patch.

SurroundingText::document is only used by the removed code, so it is also removed.

BUG=657268, 590369
Committed: https://crrev.com/eadac59641a9a79748d30a49b521e0e79822eee5
Cr-Commit-Position: refs/heads/master@{#426425}

[Xiaocheng, 2016-10-20 03:39:12]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 03:39:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-20 03:52:30]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 03:53:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-20 03:56:28]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 03:56:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-20 04:05:22]

Description was changed from

==========
Stop WebSurroundingText from storing SurroundingText with null Range

BUG=657268,590369
==========

to

==========
Remove the redundant layout update from WebSurroundingText::textContent

The only usages of WebSurroundingText are in ContentDetector::FindContentRange
and
RenderFrameImpl::OnTextSurroundingSelectionRequest, neither of which performs
any
DOM or style change between the initialization of WebSurroundingText and the
call
sites of textContent. Hence, the layout update in
WebSurroundingText::textContent
is redundant and removed by this patch.

BUG=657268,590369
==========

[Xiaocheng, 2016-10-20 04:06:24]

Description was changed from

==========
Remove the redundant layout update from WebSurroundingText::textContent

The only usages of WebSurroundingText are in ContentDetector::FindContentRange
and
RenderFrameImpl::OnTextSurroundingSelectionRequest, neither of which performs
any
DOM or style change between the initialization of WebSurroundingText and the
call
sites of textContent. Hence, the layout update in
WebSurroundingText::textContent
is redundant and removed by this patch.

BUG=657268,590369
==========

to

==========
Remove the redundant layout update from WebSurroundingText::textContent

The only usages of WebSurroundingText are in ContentDetector::FindContentRange
and
RenderFrameImpl::OnTextSurroundingSelectionRequest, neither of which performs
any
DOM or style change between the initialization of WebSurroundingText and the
call
sites of textContent. Hence, the layout update in
WebSurroundingText::textContent
is redundant and removed by this patch.

SurroundingText::document is only used by the removed code, so it is also
removed.

BUG=657268,590369
==========

[Xiaocheng, 2016-10-20 05:09:29]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-10-20 05:09:29]

PTAL.

[yosin_UTC9, 2016-10-20 05:16:30]

lgtm

[tkent, 2016-10-20 05:33:58]

lgtm

https://codereview.chromium.org/2430273006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebSurroundingText.cpp (right):

https://codereview.chromium.org/2430273006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebSurroundingText.cpp:62: // in which case we
should prevent it from being stored in |m_privated|.
m_privated -> m_private

https://codereview.chromium.org/2430273006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebSurroundingText.cpp:82: // in which case we
should prevent it from being stored in |m_privated|.
m_privated -> m_private

[Xiaocheng, 2016-10-20 05:37:48]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-10-20 05:37:49]

Thanks. Committing with typo fixed.

https://codereview.chromium.org/2430273006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebSurroundingText.cpp (right):

https://codereview.chromium.org/2430273006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebSurroundingText.cpp:62: // in which case we
should prevent it from being stored in |m_privated|.
On 2016/10/20 at 05:33:58, tkent wrote:
> m_privated -> m_private

Done.

https://codereview.chromium.org/2430273006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebSurroundingText.cpp:82: // in which case we
should prevent it from being stored in |m_privated|.
On 2016/10/20 at 05:33:58, tkent wrote:
> m_privated -> m_private

Done.

[Xiaocheng, 2016-10-20 05:37:49]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2430273006/#ps60001
(title: "fix typo")

[commit-bot: I haz the power, 2016-10-20 05:38:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 07:05:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-21 13:16:29]

Description was changed from

==========
Remove the redundant layout update from WebSurroundingText::textContent

The only usages of WebSurroundingText are in ContentDetector::FindContentRange
and
RenderFrameImpl::OnTextSurroundingSelectionRequest, neither of which performs
any
DOM or style change between the initialization of WebSurroundingText and the
call
sites of textContent. Hence, the layout update in
WebSurroundingText::textContent
is redundant and removed by this patch.

SurroundingText::document is only used by the removed code, so it is also
removed.

BUG=657268,590369
==========

to

==========
Remove the redundant layout update from WebSurroundingText::textContent

The only usages of WebSurroundingText are in ContentDetector::FindContentRange
and
RenderFrameImpl::OnTextSurroundingSelectionRequest, neither of which performs
any
DOM or style change between the initialization of WebSurroundingText and the
call
sites of textContent. Hence, the layout update in
WebSurroundingText::textContent
is redundant and removed by this patch.

SurroundingText::document is only used by the removed code, so it is also
removed.

BUG=657268,590369

Committed: https://crrev.com/eadac59641a9a79748d30a49b521e0e79822eee5
Cr-Commit-Position: refs/heads/master@{#426425}
==========

[commit-bot: I haz the power, 2016-10-21 13:16:30]

Patchset 4 (id:??) landed as
https://crrev.com/eadac59641a9a79748d30a49b521e0e79822eee5
Cr-Commit-Position: refs/heads/master@{#426425}