Issue 24302009: Correctly check for AllowHeapAllocation::IsAllowed().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24302009: Correctly check for AllowHeapAllocation::IsAllowed(). (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
Hannes Payer (out of office), adamk, rafaelw

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -5 lines)			Patch
M	src/heap.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/heap-inl.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Michael Starzinger

hpayer: PTAL. adamk,rafaelw: I will open an issue for the failing Object.observe tests. Is it ...

7 years, 3 months ago (2013-09-23 18:28:23 UTC) #1

Michael Starzinger

On 2013/09/23 18:50:32, adamk wrote: > lgtm > > Please assign to me, those tests ...

7 years, 3 months ago (2013-09-23 19:02:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16915.