Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2430183002: Move arrow scrolling into KeyboardEventManager. (Closed)
Patch Set: Add keyEvent() null check to fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 2625883bd730b4c6f3ce2e1f62e39ebb9877892a..80de218a75cefcfb06f9c9774c72a8cd3bb8a88d 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -419,11 +419,6 @@ class WEB_EXPORT WebViewImpl final
bool hasOpenedPopup() const { return m_pagePopup.get(); }
- // Returns true if the event leads to scrolling.
- static bool mapKeyCodeForScroll(int keyCode,
- ScrollDirectionPhysical*,
- ScrollGranularity*);
-
// Called by a full frame plugin inside this view to inform it that its
// zoom level has been updated. The plugin should only call this function
// if the zoom change was triggered by the browser, it's only needed in case
@@ -553,12 +548,6 @@ class WEB_EXPORT WebViewImpl final
explicit WebViewImpl(WebViewClient*, WebPageVisibilityState);
~WebViewImpl() override;
- // Returns true if the event was actually processed.
- bool keyEventDefault(const WebKeyboardEvent&);
-
- // Returns true if the view was scrolled.
- bool scrollViewWithKeyboard(int keyCode, int modifiers);
-
void hideSelectPopup();
HitTestResult hitTestResultForRootFramePos(const IntPoint&);
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698