Show drive-related settings on gear menu only when Ctrl key is pressed.

Show drive-related settings on gear menu only when Ctrl key is pressed.

Listen to Ctrl key in FileManager, and when gear menu is opened while Ctrl key is pressed, the gear menu is shown as secret mode.
The drive-related setting items will be shown only when gear menu is in secret mode and drive volume is focused.
Drive-related settings are now implemented as Comands to be consistent with other menu items.

BUG=239365
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266098

[fukino, 2014-04-21 04:48:32]

yoshiki san, could you take a look? Thanks!

[yoshiki, 2014-04-23 02:26:25]

On 2014/04/21 04:48:32, fukino wrote:
> yoshiki san, could you take a look? Thanks!

Currently a keyboard event around menu (and menu item) is handled by the command
manager, and I think ctrl-key should be handled in the command manager as well. 

We previously supported such a menuitem, which shows only when ctrlkey is
pressed. The patch which deleted the feature may help you:
https://codereview.chromium.org/153833005

[fukino, 2014-04-24 01:48:23]

On 2014/04/23 02:26:25, yoshiki wrote:
> On 2014/04/21 04:48:32, fukino wrote:
> > yoshiki san, could you take a look? Thanks!
> 
> Currently a keyboard event around menu (and menu item) is handled by the
command
> manager, and I think ctrl-key should be handled in the command manager as
well. 
> 
> We previously supported such a menuitem, which shows only when ctrlkey is
> pressed. The patch which deleted the feature may help you:
> https://codereview.chromium.org/153833005

By ctrl-key, the layout of gear menu is changed and a separator should be
removed.
The effect is beyond command's executability, so I want ctrl-key state set in
FileManager.

As further improvement, I'm going to move gear menu's UI logic from FileManager
to new class GearMenu.
Along with it, I'll move ctrl-key handling to GearMenu.

[yoshiki, 2014-04-24 05:10:47]

lgtm with nit. Thanks!

https://codereview.chromium.org/243013009/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/file_manager.js
(right):

https://codereview.chromium.org/243013009/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/file_manager.js:55:
this.isOnSecretGearMenu_ = false;
nit: How about using "isSecretGearMenuShown"?

[fukino, 2014-04-24 10:28:52]

https://codereview.chromium.org/243013009/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/file_manager.js
(right):

https://codereview.chromium.org/243013009/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/file_manager.js:55:
this.isOnSecretGearMenu_ = false;
On 2014/04/24 05:10:47, yoshiki wrote:
> nit: How about using "isSecretGearMenuShown"?

Done. Yes, it looks more readable. Thanks!

[fukino, 2014-04-24 10:36:07]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-04-24 11:07:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fukino@chromium.org/243013009/40001

[commit-bot: I haz the power, 2014-04-24 16:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 16:14:06]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[fukino, 2014-04-25 00:33:27]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-04-25 00:34:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fukino@chromium.org/243013009/40001

[commit-bot: I haz the power, 2014-04-25 02:49:01]

Change committed as 266098