Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: chrome/browser/resources/options/autofill_edit_address_overlay.html

Issue 243013004: i18n address editing in chrome://settings/autofillEditAddress. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Manual templates. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <div id="autofill-edit-address-overlay" class="page" hidden> 1 <div id="autofill-edit-address-overlay" class="page" hidden>
2 <div class="close-button"></div> 2 <div class="close-button"></div>
3 <h1 id="autofill-address-title"></h1> 3 <h1 id="autofill-address-title"></h1>
4 <div class="content-area"> 4 <div class="content-area">
5 <div> 5 <div id="autofill-edit-address-fields">
6 <div id="autofill-name-labels">
7 <span i18n-content="autofillFirstNameLabel"></span>
8 <span i18n-content="autofillMiddleNameLabel"></span>
9 <span i18n-content="autofillLastNameLabel"></span>
10 </div>
11 </div>
12 <div>
13 <list id="full-name-list"></list>
14 </div>
15
16 <label class="settings-row">
17 <div i18n-content="autofillCompanyNameLabel"></div>
18 <input id="company-name" type="text">
19 </label>
20
21 <label class="settings-row">
22 <div i18n-content="autofillAddrLine1Label"></div>
23 <input id="addr-line-1" type="text">
24 </label>
25
26 <label class="settings-row">
27 <div i18n-content="autofillAddrLine2Label"></div>
28 <input id="addr-line-2" type="text">
29 </label>
30
31 <div class="input-group settings-row">
32 <label>
33 <div i18n-content="autofillCityLabel"></div>
34 <input id="city" type="text">
35 </label>
36
37 <label>
38 <div id="state-label"></div>
39 <input id="state" type="text">
40 </label>
41
42 <label>
43 <div id="postal-code-label"></div>
44 <input id="postal-code" type="text">
45 </label>
46 </div> 6 </div>
47 7
48 <div class="settings-row"> 8 <div class="settings-row">
49 <label> 9 <label>
50 <div i18n-content="autofillCountryLabel"></div> 10 <div i18n-content="autofillCountryLabel"></div>
51 <select id="country"></select> 11 <select class="country" field="country"></select>
52 </label> 12 </label>
53 </div> 13 </div>
54 14
55 <div class="input-group settings-row"> 15 <div class="input-group settings-row">
56 <div> 16 <div>
57 <div i18n-content="autofillPhoneLabel"></div> 17 <div i18n-content="autofillPhoneLabel"></div>
58 <list id="phone-list" 18 <list class="phone-list" field="phone"
59 i18n-values="placeholder:autofillAddPhonePlaceholder"></list> 19 i18n-values="placeholder:autofillAddPhonePlaceholder"></list>
60 </div> 20 </div>
61 21
62 <div> 22 <div>
63 <div i18n-content="autofillEmailLabel"></div> 23 <div i18n-content="autofillEmailLabel"></div>
64 <list id="email-list" 24 <list class="email-list" field="email"
65 i18n-values="placeholder:autofillAddEmailPlaceholder"></list> 25 i18n-values="placeholder:autofillAddEmailPlaceholder"></list>
66 </div> 26 </div>
67 </div> 27 </div>
68
69 </div> 28 </div>
70 29
71 <div class="action-area button-strip"> 30 <div class="action-area button-strip">
72 <button id="autofill-edit-address-cancel-button" type="reset" 31 <button id="autofill-edit-address-cancel-button" type="reset"
73 i18n-content="cancel"></button> 32 i18n-content="cancel"></button>
74 <button id="autofill-edit-address-apply-button" type="submit" 33 <button id="autofill-edit-address-apply-button" type="submit"
75 class="default-button" i18n-content="ok" disabled></button> 34 class="default-button" i18n-content="ok" disabled></button>
76 </div> 35 </div>
77 </div> 36 </div>
37
38 <div hidden>
39 <div id="autofill-address-row-template" class="input-group settings-row">
40 </div>
41
42 <div id="autofill-full-name-list-template">
43 <div>
44 <div class="autofill-name-labels">
45 <span i18n-content="autofillFirstNameLabel"></span>
Evan Stade 2014/04/25 20:02:18 I think we should standardize the number of name f
please use gerrit instead 2014/04/28 15:49:44 Done.
Evan Stade 2014/04/28 23:23:16 +isherman, any opinion on this change?
Ilya Sherman 2014/04/28 23:43:44 Websites will often request first, middle, and las
Evan Stade 2014/04/28 23:56:37 Isn't the inverse also true? If we have multiple i
Ilya Sherman 2014/04/29 00:08:29 I'm not following this example. I think you mean
Evan Stade 2014/04/29 00:24:41 yes, that is what I mean.
Ilya Sherman 2014/04/29 00:37:29 Lots of web forms ask for a middle initial, so peo
Evan Stade 2014/04/29 18:19:03 Into full name fields? If the site has a middle in
Ilya Sherman 2014/04/29 18:59:20 I definitely agree that we should improve our heur
Evan Stade 2014/04/29 19:14:31 Yes, this is a tangent. But it also matters to thi
Ilya Sherman 2014/04/29 19:25:03 For names in English, we don't tokenize correctly,
Evan Stade 2014/04/30 05:25:22 Yao Ming goes by surname-givenname in English. I'm
46 <span i18n-content="autofillMiddleNameLabel"></span>
47 <span i18n-content="autofillLastNameLabel"></span>
48 </div>
49 </div>
50 <div>
51 <list class="full-name-list" field="fullName"></list>
Evan Stade 2014/04/25 20:02:18 why is this a list inside a div, whereas below you
please use gerrit instead 2014/04/28 15:49:44 No longer relevant, as we're no longer using first
52 </div>
53 </div>
54
55 <div id="autofill-addr-lines-template">
Evan Stade 2014/04/25 20:02:18 hmm, this should be a textarea, if we are going to
please use gerrit instead 2014/04/28 15:49:44 Done.
56 <div i18n-content="autofillAddrLinesLabel"></div>
57 <list class="addr-lines" field="addrLines"
58 i18n-values="placeholder:autofillAddAddrLinePlaceholder"></list>
59 </div>
60
61 <label id="autofill-field-template">
62 <div></div>
63 <input type="text">
64 </label>
65 </div>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698