Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 243007: Retry r27137. Create renderers for ExtensionHosts one at a time to avoid blocking the UI. (Closed)

Created:
11 years, 2 months ago by Matt Perry
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Retry r27137. Create renderers for ExtensionHosts one at a time to avoid blocking the UI. I added a process.Close() to the fast shutdown path for renderers. The problem was that we were trying to use an old terminated process handle. BUG=14040 TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The UI should be responsive while the toolstrips are loading. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27434

Patch Set 1 #

Patch Set 2 : fix linux crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -15 lines) Patch
M chrome/browser/cocoa/extension_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.h View 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 4 chunks +70 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/extension_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 5 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/extensions/extension_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Matt Perry
This is the same as the last CL, but with changes to browser_render_process_host.cc.
11 years, 2 months ago (2009-09-25 21:06:34 UTC) #1
Erik does not do reviews
11 years, 2 months ago (2009-09-25 21:10:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698