Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4502)

Unified Diff: chrome/browser/chromeos/options/network_config_view.h

Issue 2430003002: NetworkConnect::Delegate: service_path -> network_id (Closed)
Patch Set: Rebase, move guid lookup Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/public/interfaces/system_tray.mojom ('k') | chrome/browser/chromeos/options/network_config_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/options/network_config_view.h
diff --git a/chrome/browser/chromeos/options/network_config_view.h b/chrome/browser/chromeos/options/network_config_view.h
index 9d83221efb108bb6a035c6c8afd94787c7abc217..84de8fa6cdbf678cb0d73b7b3a72ad59d9cabcd9 100644
--- a/chrome/browser/chromeos/options/network_config_view.h
+++ b/chrome/browser/chromeos/options/network_config_view.h
@@ -46,6 +46,11 @@ class NetworkConfigView : public views::DialogDelegateView,
// Shows a network connection dialog if none is currently visible.
static void Show(const std::string& service_path, gfx::NativeWindow parent);
+
+ // Same as above but tahes a network id (GUID) instead.
James Cook 2016/10/19 18:10:15 nit: tahes -> takes
+ static void ShowByNetworkId(const std::string& network_id,
+ gfx::NativeWindow parent);
+
// Shows a dialog to configure a new network. |type| must be a valid Shill
// 'Type' property value.
static void ShowForType(const std::string& type, gfx::NativeWindow parent);
@@ -86,6 +91,9 @@ class NetworkConfigView : public views::DialogDelegateView,
NetworkConfigView();
~NetworkConfigView() override;
+ static void ShowByNetwork(const NetworkState* network,
+ gfx::NativeWindow parent);
+
// Login dialog for known networks. Returns true if successfully created.
bool InitWithNetworkState(const NetworkState* network);
// Login dialog for new/hidden networks. Returns true if successfully created.
« no previous file with comments | « ash/public/interfaces/system_tray.mojom ('k') | chrome/browser/chromeos/options/network_config_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698