Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: ui/events/blink/compositor_thread_event_queue.cc

Issue 2429953002: Implement compositor thread VSync aligned event queue (Closed)
Patch Set: dtapuska's review: Non-template CompositorThreadEventQueue; Added blink_features.h; UMA only when e… Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/blink/compositor_thread_event_queue.cc
diff --git a/ui/events/blink/compositor_thread_event_queue.cc b/ui/events/blink/compositor_thread_event_queue.cc
new file mode 100644
index 0000000000000000000000000000000000000000..43a145a30b974666ba671278268539bc32566fe5
--- /dev/null
+++ b/ui/events/blink/compositor_thread_event_queue.cc
@@ -0,0 +1,32 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/events/blink/compositor_thread_event_queue.h"
+
+namespace ui {
+
+CompositorThreadEventQueue::CompositorThreadEventQueue() {}
+
+CompositorThreadEventQueue::~CompositorThreadEventQueue() {}
+
+void CompositorThreadEventQueue::Queue(
+ std::unique_ptr<EventWithCallback> event) {
+ if (!queue_.empty() && queue_.back()->CanCoalesceWith(*event)) {
tdresser 2016/11/01 18:12:44 This doesn't handle the scroll/pinch/scroll case,
chongz 2016/11/02 21:29:32 No it doesn't. I've filed https://crbug.com/661601
tdresser 2016/11/04 16:51:03 Next CL is fine.
+ queue_.back()->CoalesceWith(event.get());
+ return;
+ }
+
+ queue_.emplace_back(std::move(event));
+}
+
+std::unique_ptr<EventWithCallback> CompositorThreadEventQueue::Pop() {
+ std::unique_ptr<EventWithCallback> result;
+ if (!queue_.empty()) {
+ result.reset(queue_.front().release());
+ queue_.pop_front();
+ }
+ return result;
+}
+
+} // namespace ui

Powered by Google App Engine
This is Rietveld 408576698