ui/events/blink/blink_features.cc - Issue 2429953002: Implement compositor thread VSync aligned event queue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/events/blink/blink_features.cc

Issue 2429953002: Implement compositor thread VSync aligned event queue (Closed)

Patch Set: dtapuska's review: Non-template CompositorThreadEventQueue; Added blink_features.h; UMA only when e… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/events/blink/blink_features.h"

	6

	7 namespace features {

	8

	9 // VSync aligned input events support.

	10 const base::Feature kVsyncAlignedInputEvents{"VsyncAlignedInput",

	11 base::FEATURE_DISABLED_BY_DEFAULT};

	12 }
	tdresser 2016/11/01 18:12:43 newline before }, update comment. newline before }, update comment. chongz 2016/11/02 21:29:32 Done. It was removed by 'cl format'. Show quoted text On 2016/11/01 18:12:43, tdresser wrote: > newline before }, update comment. Done. It was removed by 'cl format'. tdresser 2016/11/04 16:51:03 If git cl format removes the whitespace, then perh Show quoted text On 2016/11/02 21:29:32, chongz wrote: > On 2016/11/01 18:12:43, tdresser wrote: > > newline before }, update comment. > > Done. It was removed by 'cl format'. If git cl format removes the whitespace, then perhaps to make it consistent, we should instead have removed the newline after "namespace features {"? chongz 2016/11/08 21:59:22 Just checked other files in this directory, and it Show quoted text On 2016/11/04 16:51:03, tdresser wrote: > On 2016/11/02 21:29:32, chongz wrote: > > On 2016/11/01 18:12:43, tdresser wrote: > > > newline before }, update comment. > > > > Done. It was removed by 'cl format'. > > If git cl format removes the whitespace, then perhaps to make it consistent, we > should instead have removed the newline after > > "namespace features {"? Just checked other files in this directory, and it seems to be bug of cl-format and we should have newline before&after namespace.
OLD	NEW