Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4638)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.h

Issue 2429943002: Remove all synchronous methods from OfflinePageBridge. (Closed)
Patch Set: Fix a test and address nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bridge.h
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.h b/chrome/browser/android/offline_pages/offline_page_bridge.h
index 24974ae906eb487552ec2404ba17cb0f40b68559..c5ba32ae2ca00630fd44a39a4821266a1281e243 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.h
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.h
@@ -55,16 +55,26 @@ class OfflinePageBridge : public OfflinePageModel::Observer,
const base::android::JavaParamRef<jobject>& j_result_obj,
const base::android::JavaParamRef<jobject>& j_callback_obj);
- base::android::ScopedJavaLocalRef<jlongArray> GetOfflineIdsForClientId(
+ void GetPageByOfflineId(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jstring>& j_namespace,
- const base::android::JavaParamRef<jstring>& j_client_id);
+ jlong offline_id,
+ const base::android::JavaParamRef<jobject>& j_callback_obj);
+
+ void DeletePagesByClientId(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jobjectArray>& j_namespaces_array,
+ const base::android::JavaParamRef<jobjectArray>& j_ids_array,
+ const base::android::JavaParamRef<jobject>& j_callback_obj);
- base::android::ScopedJavaLocalRef<jobject> GetPageByOfflineId(
+ void GetPagesByClientId(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
- jlong offline_id);
+ const base::android::JavaParamRef<jobject>& j_result_obj,
+ const base::android::JavaParamRef<jobjectArray>& j_namespaces_array,
+ const base::android::JavaParamRef<jobjectArray>& j_ids_array,
+ const base::android::JavaParamRef<jobject>& j_callback_obj);
void SelectPageForOnlineUrl(
JNIEnv* env,
@@ -88,12 +98,6 @@ class OfflinePageBridge : public OfflinePageModel::Observer,
const base::android::JavaParamRef<jstring>& j_client_id,
jboolean user_requested);
- void DeletePages(
- JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jobject>& j_callback_obj,
- const base::android::JavaParamRef<jlongArray>& j_offline_ids_array);
-
base::android::ScopedJavaLocalRef<jstring> GetOfflinePageHeaderForReload(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,

Powered by Google App Engine
This is Rietveld 408576698