ui/views/controls/native/native_view_host_wrapper.h - Issue 24299004: Implement features in NativeViewHostAura for scroll end effect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/native/native_view_host_wrapper.h

Issue 24299004: Implement features in NativeViewHostAura for scroll end effect (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Responsed to sky's comments and finished tests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/native/native_view_host_wrapper.h

diff --git a/ui/views/controls/native/native_view_host_wrapper.h b/ui/views/controls/native/native_view_host_wrapper.h

index 3b3cb37fbdc0b5382b8819ca7223a0b4f88b28fd..7a305c16a0057ca827199f7335b9582237b6cb7e 100644

--- a/ui/views/controls/native/native_view_host_wrapper.h

+++ b/ui/views/controls/native/native_view_host_wrapper.h

@@ -19,10 +19,10 @@ class VIEWS_EXPORT NativeViewHostWrapper {

public:

virtual ~NativeViewHostWrapper() {}

- // Called right before a gfx::NativeView is attached to the associated

- // NativeViewHost, allowing the wrapper to perform platform-specific

- // initialization.

- virtual void NativeViewWillAttach() = 0;

+ // Called at the end of NativeViewHost::Attach, allowing the wrapper to

+ // perform platform-specific operations that need to occur to complete

+ // attaching the gfx::NativeView.

+ virtual void AttachNativeView() = 0;

// Called before the attached gfx::NativeView is detached from the

// NativeViewHost, allowing the wrapper to perform platform-specific