Implement features in NativeViewHostAura for scroll end effect

ui/views/controls/native/native_view_host_aura.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_NATIVE_NATIVE_VIEW_HOST_AURA_H_
 #define UI_VIEWS_CONTROLS_NATIVE_NATIVE_VIEW_HOST_AURA_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
 #include "ui/aura/window_observer.h"
+#include "ui/compositor/layer.h"
 #include "ui/views/controls/native/native_view_host_wrapper.h"
 #include "ui/views/views_export.h"
 
 namespace views {
 
 class NativeViewHost;
 
 // Aura implementation of NativeViewHostWrapper.
 class VIEWS_EXPORT NativeViewHostAura : public NativeViewHostWrapper,
                                         public aura::WindowObserver {
@@ skipping 11 matching lines @@
   virtual void UninstallClip() OVERRIDE;
   virtual void ShowWidget(int x, int y, int w, int h) OVERRIDE;
   virtual void HideWidget() OVERRIDE;
   virtual void SetFocus() OVERRIDE;
   virtual gfx::NativeViewAccessible GetNativeViewAccessible() OVERRIDE;
 
  private:
   // Overridden from aura::WindowObserver:
   virtual void OnWindowDestroyed(aura::Window* window) OVERRIDE;
 
+  gfx::Point CalculateNewNativeViewOrigin(gfx::Rect input_rect,

[sky, 2013/09/24 20:23:25]

const gfx::Rect& on these (same for CalculateCLipOrigin).

Also, add description for all members (eg GetWidthFactory, orig_bounds_...)

[rharrison, 2013/09/26 20:36:48]

Done.

+                                          gfx::Rect native_rect) const;
+  gfx::Point CalculateClipOrigin(gfx::Rect input_rect,
+                                 gfx::Rect native_rect) const;
+  float GetWidthFactor() const;
+  float GetHeightFactor() const;
+
   // Our associated NativeViewHost.
   NativeViewHost* host_;
 
   // Have we installed a clip region?
   bool installed_clip_;
 
+  scoped_ptr<ui::Layer> clipping_layer_;

[sky, 2013/09/24 20:23:25]

If the life of clipping_layer is the same as NVHA, then no point in using
scoped_ptr. Well, actually you could use it to avoid the header include, but
style guide says no to that.

[rharrison, 2013/09/26 20:36:48]

Done.

+
+  gfx::Rect orig_bounds_;
+
   DISALLOW_COPY_AND_ASSIGN(NativeViewHostAura);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_NATIVE_NATIVE_VIEW_HOST_AURA_H_