Implement features in NativeViewHostAura for scroll end effect

ui/views/controls/native/native_view_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_NATIVE_NATIVE_VIEW_HOST_H_
 #define UI_VIEWS_CONTROLS_NATIVE_NATIVE_VIEW_HOST_H_
 
 #include <string>
 
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/view.h"
 
 namespace views {
 
 class NativeViewHostAuraTest;
 class NativeViewHostWrapper;
 
+// When performing fast resizes the contents is not actually resized, but
+// instead the contents is positioned and clipped to give the impression of
+// resizing. Gravity indicates the positioning of the content relative to the
+// clipping. The default value, northwest, indicates that the top left corner of
+// the clip and the content should align, so the bottom and left sides of the

[sky, 2013/09/24 20:23:25]

left -> right

[rharrison, 2013/09/26 20:36:48]

Done.

+// content will be clipped. For a value like south the bottom edges will align
+// at their respective middles, thus the full vertical resize will be reflected
+// on the top, but half of the horizontal resize will be reflected on the left
+// and right sides. The following list is the gravity values and their alignment
+// points for reference, coordinates relative to the respective system for the
+// clip or contents:
+//   NorthWest      (0, 0)
+//   North          (width/2, 0)
+//   NorthEast      (width, 0)
+//   East           (width, height/2)
+//   SouthEast      (width, height)
+//   South          (width/2, height)
+//   SouthWest      (0, height)
+//   West           (0, height/2)
+//   Center         (width/2, height/2)
+enum FastResizeGravity {

[sky, 2013/09/24 20:23:25]

I'm not opposed to all of these, but do we really need them all?

[sky, 2013/09/24 20:23:25]

Could you also make this a member of NativeViewHost.

[rharrison, 2013/09/26 20:36:48]

The default is NW and I would need a southern one for the effect I am working
on, but we don't need them all at the moment. I was following along with what
Xlib does, so decided to do the 8 directions plus centre. 

I am peronally implementing them all since it seems a little weird to me to have
just a few of the directions implemented, but not all of them. The additional
directions don't require substantial or complex code to support them, just
additional simple case statements. If there needed to be special handling or
more involved code then I would be more concerned.

[rharrison, 2013/09/26 20:36:48]

Done.

+  FAST_RESIZE_GRAVITY_NORTHWEST,
+  FAST_RESIZE_GRAVITY_NORTH,
+  FAST_RESIZE_GRAVITY_NORTHEAST,
+  FAST_RESIZE_GRAVITY_EAST,
+  FAST_RESIZE_GRAVITY_SOUTHEAST,
+  FAST_RESIZE_GRAVITY_SOUTH,
+  FAST_RESIZE_GRAVITY_SOUTHWEST,
+  FAST_RESIZE_GRAVITY_WEST,
+  FAST_RESIZE_GRAVITY_CENTER,
+};
+
 // If a NativeViewHost's native view is a Widget, this native window
 // property is set on the widget, pointing to the owning NativeViewHost.
 extern const char kWidgetNativeViewHostKey[];
 
 // A View type that hosts a gfx::NativeView. The bounds of the native view are
 // kept in sync with the bounds of this view as it is moved and sized.
 // Under the hood, a platform-specific NativeViewHostWrapper implementation does
 // the platform-specific work of manipulating the underlying OS widget type.
 class VIEWS_EXPORT NativeViewHost : public View {
  public:
@@ skipping 39 matching lines @@
   // and don't care about accuracy. Make sure you do a real resize at the
   // end. USE WITH CAUTION.
   void set_fast_resize(bool fast_resize) { fast_resize_ = fast_resize; }
   bool fast_resize() const { return fast_resize_; }
 
   // Value of fast_resize() the last time Layout() was invoked.
   bool fast_resize_at_last_layout() const {
     return fast_resize_at_last_layout_;
   }
 
+  // Gravity controls how the clip is positioned relative to the native
+  // view. The specifics of this are discussed in the comment above the related
+  // enum. This call only sets the value being used, but does not cause a
+  // re-layout, so ShowWidget, via Layout, must be called before the new gravity
+  // will have an effect.
+  void set_fast_resize_gravity(FastResizeGravity gravity) {
+    fast_resize_gravity_ = gravity;
+  }
+  FastResizeGravity fast_resize_gravity() {
+    return fast_resize_gravity_;
+  }
+
   // Accessor for |native_view_|.
   gfx::NativeView native_view() const { return native_view_; }
 
   void NativeViewDestroyed();
 
   // Overridden from View:
   virtual gfx::Size GetPreferredSize() OVERRIDE;
   virtual void Layout() OVERRIDE;
   virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
   virtual void VisibilityChanged(View* starting_from, bool is_visible) OVERRIDE;
@@ skipping 29 matching lines @@
   // The preferred size of this View
   gfx::Size preferred_size_;
 
   // True if the native view is being resized using the fast method described
   // in the setter/accessor above.
   bool fast_resize_;
 
   // Value of |fast_resize_| during the last call to Layout.
   bool fast_resize_at_last_layout_;
 
+  // gravity value to be used on the next call to ShowWidget.
+  FastResizeGravity fast_resize_gravity_;
+
   // The view that should be given focus when this NativeViewHost is focused.
   View* focus_view_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeViewHost);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_NATIVE_NATIVE_VIEW_HOST_H_