Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2429873002: fix translate breakage under de_DE.UTF8 and other locale by avoiding locale sensitve formatting for… (Closed)

Created:
4 years, 2 months ago by ftang
Modified:
4 years, 1 month ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix translate breakage under de_DE.UTF8 and other locale by avoiding locale sensitve formatting for float point BUG=656922 Committed: https://crrev.com/b9d0a55329d102f77806a432896795e24b2bb916 Cr-Commit-Position: refs/heads/master@{#427492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/translate/core/browser/translate_script.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
ftang
This break Translate when the Chrome is running on certain Locale which the decimal point ...
4 years, 2 months ago (2016-10-18 17:35:58 UTC) #4
groby-ooo-7-16
lgtm
4 years, 1 month ago (2016-10-25 19:24:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429873002/1
4 years, 1 month ago (2016-10-25 21:00:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 21:46:53 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 21:49:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9d0a55329d102f77806a432896795e24b2bb916
Cr-Commit-Position: refs/heads/master@{#427492}

Powered by Google App Engine
This is Rietveld 408576698