Disable some API calls in networkingPrivate for non-primary user

chromeos/login/login_state.h

Index: chromeos/login/login_state.h
diff --git a/chromeos/login/login_state.h b/chromeos/login/login_state.h
index 246bab9fe38a6defa98898ddcc9b2dffd15cb810..6d403620698fc12a2e567828f4b13d4f97f028d7 100644
--- a/chromeos/login/login_state.h
+++ b/chromeos/login/login_state.h
@@ -51,10 +51,18 @@ class CHROMEOS_EXPORT LoginState {
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
-  // Set the logged in state and user type.
+  // Sets the logged in state, user type, and primary user hash. Also notifies

[pneubeck (no reviews), 2014/06/12 09:51:01]

I find this interface a bit odd in the light of multiple users / logins.

Could you either clarify what is supposed to be called on each login if
multiprofile is available?

Would it be safer to have only a single function which is to be called on the
first login no matter if we use multiprofile or not (or maybe even on every
login); so that it forces the caller to think about the correct arguments?

Don't we still ignore logouts completely? Shouldn't the interface convey that
too (at least comment)?

E.g.
// Sets LoggedInState to LOGGED_IN_ACTIVE. Must be called at first
// login and at most once during the lifetime of this object.
SetFirstLogin(LoggedInUserType type, const std::string& user_hash);

// Must be called on each login after the initial login during the
// same sesson.
SetSecondaryLogins(const std::string& user_hash);

alternatively, a single function:
// Must be called on every login. Secondary logins must match the
// type of the primary login.
OnLogin(LoggedInUserType type, const std::string& user_hash);

(not sure what a good prefix is: On-/Set-/...?)

[stevenjb, 2014/06/12 20:27:51]

This should be called exactly once when a user logs in. I will add that to the
comment.

The reason I didn't just add "SetPrimaryUser" is that I didn't want to
complicate the observer model and requiring "SetPrimaryUser" to be called before
"SetLoggedInState" would be awkward.

My understanding is that login/User will be getting moved (finally!) to
src/chromeos at which point we should be able to get rid of this class entirely.

+  // observers.
+  void SetLoggedInStateAndPrimaryUser(
+      LoggedInState state,
+      LoggedInUserType type,
+      const std::string& primary_user_hash);
+
+  // Sets the logged in state and user type. Also notifies observers. Used
+  // in tests or situations where there is no primary user.
   void SetLoggedInState(LoggedInState state, LoggedInUserType type);
 
-  // Get the logged in user type.
+  // Gets the logged in user type.
   LoggedInUserType GetLoggedInUserType() const;
 
   // Returns true if a user is considered to be logged in.
@@ -84,6 +92,8 @@ class CHROMEOS_EXPORT LoginState {
     always_logged_in_ = always_logged_in;
   }
 
+  const std::string& primary_user_hash() const { return primary_user_hash_; }
+
  private:
   LoginState();
   virtual ~LoginState();
@@ -92,6 +102,7 @@ class CHROMEOS_EXPORT LoginState {
 
   LoggedInState logged_in_state_;
   LoggedInUserType logged_in_user_type_;
+  std::string primary_user_hash_;
   ObserverList<Observer> observer_list_;
 
   // If true, it always thinks the current status as logged in. Set to true by