Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2429763002: X87: [turbofan]: Micro optimizations to lea[l/q] on ia32/x64. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan]: Micro optimizations to lea[l/q] on ia32/x64. port 87ae05c7c418bee367a2006f0658a3dd171ed619 (r40341) original commit message: Utilize all opportunities to turn leas into adds. BUG= Committed: https://crrev.com/1107aa8b7490f9a2f3f7cdabd9ddefdd62fcc88a Cr-Commit-Position: refs/heads/master@{#40386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-18 07:18:23 UTC) #2
Weiliang
lgtm
4 years, 2 months ago (2016-10-18 07:46:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429763002/1
4 years, 2 months ago (2016-10-18 07:47:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 08:10:28 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 08:11:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1107aa8b7490f9a2f3f7cdabd9ddefdd62fcc88a
Cr-Commit-Position: refs/heads/master@{#40386}

Powered by Google App Engine
This is Rietveld 408576698