Issue 242973004: Get sample_app running on Android again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 242973004: Get sample_app running on Android again (Closed)

Created:
6 years, 8 months ago by DaveMoore

Modified:
6 years, 8 months ago

Reviewers:

CC:
chromium-reviews, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, ben+mojo_chromium.org, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get sample_app running on Android again Second try after first broke build https://codereview.chromium.org/240003006/ TBR=viettrungluu BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265070

Patch Set 1 #

Patch Set 2 : Check for component build in export #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -31 lines)			Patch
M	build/android/adb_run_mojo_shell	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/mojo_examples.gypi	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	mojo/mojo_public.gypi	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	mojo/mojo_services.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/services/native_viewport/native_viewport_export.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	mojo/shell/android/mojo_main.cc	View		3 chunks	+5 lines, -27 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

6 years, 8 months ago (2014-04-21 21:12:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r265070 (presubmit successful).

Expand Messages | Collapse Messages