Issue 242973003: Clean up kerning and color-profile leftovers

Issue 242973003: Clean up kerning and color-profile leftovers (Closed)

Created:
6 years, 8 months ago by rwlbuis

Modified:
6 years, 8 months ago

Reviewers:
pdr., vsevik, pfeldman

CC:
blink-reviews, eae+blinkwatch, fs, apavlov+blink_chromium.org, adamk+blink_chromium.org, kouhei+svg_chromium.org, ojan, caseq+blink_chromium.org, krit, malch+blink_chromium.org, yurys+blink_chromium.org, aandrey+blink_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Clean up kerning and color-profile leftovers Strip kerning from two batik tests and mark them as needing a rebaseline. BUG=365171 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172032

Patch Set 1 #

Patch Set 2 : Fix mac tests #

Patch Set 3 : Another attempt #

Patch Set 4 : Fix Mac part II #

Patch Set 5 : Mark tests in TestExpectations #

Patch Set 6 : strip devtools change #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -31 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	LayoutTests/svg/batik/text/textLayout.svg	View		2 chunks	+0 lines, -10 lines	0 comments	Download
M	LayoutTests/svg/batik/text/textOnPathSpaces.svg	View		2 chunks	+0 lines, -19 lines	0 comments	Download
M	Source/core/dom/DOMImplementation.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGTagNames.in	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

pdr.

On 2014/04/18 23:47:08, rwlbuis wrote: > PTAL :) LGTM but you'll want to add a ...

6 years, 8 months ago (2014-04-18 23:51:40 UTC) #2

rwlbuis

On 2014/04/18 23:51:40, pdr wrote: > On 2014/04/18 23:47:08, rwlbuis wrote: > > PTAL :) ...

6 years, 8 months ago (2014-04-19 00:16:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/242973003/120001

6 years, 8 months ago (2014-04-21 00:01:02 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-21 00:19:20 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on blink_presubmit

6 years, 8 months ago (2014-04-21 00:19:20 UTC) #7

pdr.

On 2014/04/21 00:19:20, I haz the power (commit-bot) wrote: > Try jobs failed on following ...

6 years, 8 months ago (2014-04-21 00:30:51 UTC) #8

pfeldman

We'll need to apply changes to css.js upstream and pick it with the next cm ...

6 years, 8 months ago (2014-04-21 09:28:50 UTC) #9

lushnikov

Upstream pull-request: https://github.com/marijnh/CodeMirror/pull/2483 So far we can discard changes in cm/css.js in this patch, hopefully ...

6 years, 8 months ago (2014-04-21 09:58:07 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/242973003/130001

6 years, 8 months ago (2014-04-21 12:48:08 UTC) #12

Message was sent while issue was closed.

Change committed as 172032

Expand Messages | Collapse Messages