Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2429723005: Revert of [serializer] add test case for unknown external references. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [serializer] add test case for unknown external references. (patchset #3 id:40001 of https://codereview.chromium.org/2428463002/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/2428853002/ Original issue's description: > [serializer] add test case for unknown external references. > > Unknown external references must trigger assertion failure. > > Committed: https://crrev.com/0655c45986eedfc2948d3b47ccac9ed57533e524 > Cr-Commit-Position: refs/heads/master@{#40391} TBR=jochen@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -41 lines) Patch
M src/snapshot/serializer-common.cc View 2 chunks +1 line, -12 lines 0 comments Download
M test/cctest/cctest.status View 2 chunks +1 line, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +3 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [serializer] add test case for unknown external references.
4 years, 2 months ago (2016-10-18 13:23:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429723005/1
4 years, 2 months ago (2016-10-18 13:23:38 UTC) #3
commit-bot: I haz the power
Failed to apply patch for src/snapshot/serializer-common.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 2 months ago (2016-10-18 13:23:42 UTC) #5
Michael Achenbach
4 years, 2 months ago (2016-10-18 13:29:01 UTC) #6
Message was sent while issue was closed.
Abandoning this in favor of the fix.

Powered by Google App Engine
This is Rietveld 408576698