Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 24296002: Sandbox: Update for Windows 8.1 (Closed)

Created:
7 years, 3 months ago by rvargas (doing something else)
Modified:
7 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Sandbox: Update for Windows 8.1 Some AppContainer methods moved to another DLL and the address space for 64-bit apps is larger than before. BUG=none TEST=current sbox_unittests, sbox_integration_tests, sbox_validation_tests R=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224489

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -26 lines) Patch
M sandbox/win/src/app_container.cc View 4 chunks +19 lines, -11 lines 0 comments Download
M sandbox/win/src/internal_types.h View 2 chunks +4 lines, -3 lines 0 comments Download
M sandbox/win/src/sandbox_nt_util.cc View 1 3 chunks +15 lines, -12 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
rvargas (doing something else)
7 years, 3 months ago (2013-09-19 22:09:24 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/24296002/diff/26001/sandbox/win/src/sandbox_nt_util.cc File sandbox/win/src/sandbox_nt_util.cc (right): https://codereview.chromium.org/24296002/diff/26001/sandbox/win/src/sandbox_nt_util.cc#newcode33 sandbox/win/src/sandbox_nt_util.cc:33: for (; attempts < 41; attempts++) { I ...
7 years, 3 months ago (2013-09-20 02:40:38 UTC) #2
rvargas (doing something else)
https://codereview.chromium.org/24296002/diff/26001/sandbox/win/src/sandbox_nt_util.cc File sandbox/win/src/sandbox_nt_util.cc (right): https://codereview.chromium.org/24296002/diff/26001/sandbox/win/src/sandbox_nt_util.cc#newcode33 sandbox/win/src/sandbox_nt_util.cc:33: for (; attempts < 41; attempts++) { On 2013/09/20 ...
7 years, 3 months ago (2013-09-20 02:42:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/24296002/26001
7 years, 3 months ago (2013-09-20 02:44:05 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=199808
7 years, 3 months ago (2013-09-20 07:33:22 UTC) #5
cpu_(ooo_6.6-7.5)
hmmm, CQing again.
7 years, 3 months ago (2013-09-20 14:55:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/24296002/26001
7 years, 3 months ago (2013-09-20 14:56:27 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=200178
7 years, 3 months ago (2013-09-20 20:23:04 UTC) #8
rvargas (doing something else)
7 years, 3 months ago (2013-09-20 21:10:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r224489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698