Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: scripts/slave/chromium/archive_layout_test_results_unittest.py

Issue 2429573002: Also archive diff files in layout-test-results.zip. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/chromium/archive_layout_test_results_unittest.py
diff --git a/scripts/slave/chromium/archive_layout_test_results_unittest.py b/scripts/slave/chromium/archive_layout_test_results_unittest.py
index fb4471bfb66a547bcedaea3074bba5e50aca6028..c92c11859c4ff3e5d1f0774560effc2e70d570c0 100755
--- a/scripts/slave/chromium/archive_layout_test_results_unittest.py
+++ b/scripts/slave/chromium/archive_layout_test_results_unittest.py
@@ -38,6 +38,18 @@ class ArchiveLayoutTestResultsTest(unittest.TestCase):
self.assertFalse(archive_layout_test_results._IsActualResultFile(
'foo-actual.html'))
+ def test_IsDiffFile(self):
+ self.assertTrue(archive_layout_test_results._IsDiffFile('a-diff.png'))
+ self.assertTrue(archive_layout_test_results._IsDiffFile('a-diff.txt'))
+ self.assertTrue(archive_layout_test_results._IsDiffFile('a-wdiff.txt'))
+ self.assertTrue(archive_layout_test_results._IsDiffFile('a-expected.txt'))
+ self.assertTrue(archive_layout_test_results._IsDiffFile('a-expected.html'))
+
+ self.assertFalse(archive_layout_test_results._IsDiffFile('a-diff.png.foo'))
+ self.assertFalse(archive_layout_test_results._IsDiffFile('a-diff.png.foo'))
+ self.assertFalse(archive_layout_test_results._IsDiffFile('foo-actual.html'))
+ self.assertFalse(archive_layout_test_results._IsDiffFile('results.html'))
+
if __name__ == '__main__':
unittest.main()

Powered by Google App Engine
This is Rietveld 408576698