Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2429563002:
Enable more browser tests that now pass with PlzNavigate. (Closed)
DescriptionEnable more browser tests that now pass with PlzNavigate.
BUG=504347
Committed: https://crrev.com/191d96c79f9cd31a40ba1923a29aa7a82aafce79
Committed: https://crrev.com/8a774e21be378fdbc81b5e74d3e2e2056b1b6229
Cr-Original-Commit-Position: refs/heads/master@{#425725}
Cr-Commit-Position: refs/heads/master@{#426057}
Patch Set 1 #Patch Set 2 : reland without ExtensionWebRequestApiTest.WebRequestDeclarative2 #Messages
Total messages: 24 (13 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
jam@chromium.org changed reviewers: + scottmg@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by jam@chromium.org
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable more browser tests that now pass with PlzNavigate. BUG=504347 ========== to ========== Enable more browser tests that now pass with PlzNavigate. BUG=504347 Committed: https://crrev.com/191d96c79f9cd31a40ba1923a29aa7a82aafce79 Cr-Commit-Position: refs/heads/master@{#425725} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/191d96c79f9cd31a40ba1923a29aa7a82aafce79 Cr-Commit-Position: refs/heads/master@{#425725}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2430523002/ by joedow@chromium.org. The reason for reverting is: CL is suspected to be be causing failures on multiple Linux bots (ExtensionWebRequestApiTest.WebRequestDeclarative2 is failing): https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%... .
Message was sent while issue was closed.
Description was changed from ========== Enable more browser tests that now pass with PlzNavigate. BUG=504347 Committed: https://crrev.com/191d96c79f9cd31a40ba1923a29aa7a82aafce79 Cr-Commit-Position: refs/heads/master@{#425725} ========== to ========== Enable more browser tests that now pass with PlzNavigate. BUG=504347 Committed: https://crrev.com/191d96c79f9cd31a40ba1923a29aa7a82aafce79 Cr-Commit-Position: refs/heads/master@{#425725} ==========
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2429563002/#ps20001 (title: "reland without ExtensionWebRequestApiTest.WebRequestDeclarative2")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable more browser tests that now pass with PlzNavigate. BUG=504347 Committed: https://crrev.com/191d96c79f9cd31a40ba1923a29aa7a82aafce79 Cr-Commit-Position: refs/heads/master@{#425725} ========== to ========== Enable more browser tests that now pass with PlzNavigate. BUG=504347 Committed: https://crrev.com/191d96c79f9cd31a40ba1923a29aa7a82aafce79 Cr-Commit-Position: refs/heads/master@{#425725} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable more browser tests that now pass with PlzNavigate. BUG=504347 Committed: https://crrev.com/191d96c79f9cd31a40ba1923a29aa7a82aafce79 Cr-Commit-Position: refs/heads/master@{#425725} ========== to ========== Enable more browser tests that now pass with PlzNavigate. BUG=504347 Committed: https://crrev.com/191d96c79f9cd31a40ba1923a29aa7a82aafce79 Committed: https://crrev.com/8a774e21be378fdbc81b5e74d3e2e2056b1b6229 Cr-Original-Commit-Position: refs/heads/master@{#425725} Cr-Commit-Position: refs/heads/master@{#426057} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8a774e21be378fdbc81b5e74d3e2e2056b1b6229 Cr-Commit-Position: refs/heads/master@{#426057} |
