Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2429533004: Revert of ChromeOS: Add unittest for ConvertPathToArcUrl. (Closed)

Created:
4 years, 2 months ago by kinaba
Modified:
4 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org, Daniel Erat, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ChromeOS: Add unittest for ConvertPathToArcUrl. (patchset #1 id:1 of https://codereview.chromium.org/2426873002/ ) Reason for revert: It broke a bot https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/37447/steps/unit_tests%20on%20Ubuntu-12.04/logs/FileManagerPathUtilTest.ConvertPathToArcUrl Original issue's description: > ChromeOS: Add unittest for ConvertPathToArcUrl. > > BUG=612720 > TEST=unit_tests --gtest_filter='FileManagerPathUtilTest.ConvertPathToArcUrl' > > Committed: https://crrev.com/6b8f55438bb39e8cc37b76f97abf64683c476977 > Cr-Commit-Position: refs/heads/master@{#425905} TBR=fukino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612720 Committed: https://crrev.com/74c4cbc587e14a76bbc26cbf8f7b98f97cbc080b Cr-Commit-Position: refs/heads/master@{#425914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -52 lines) Patch
M chrome/browser/chromeos/file_manager/path_util_unittest.cc View 2 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kinaba
Created Revert of ChromeOS: Add unittest for ConvertPathToArcUrl.
4 years, 2 months ago (2016-10-18 07:05:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429533004/1
4 years, 2 months ago (2016-10-18 07:05:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 07:06:18 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 07:08:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74c4cbc587e14a76bbc26cbf8f7b98f97cbc080b
Cr-Commit-Position: refs/heads/master@{#425914}

Powered by Google App Engine
This is Rietveld 408576698