Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

Issue 2429523002: Cleanup desktop NTP metrics recording (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
index 6187e3734cf83e1e6bb2424831af892b035dd0ca..9a543dd35727d94256592f0b06095cbfd1297385 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
@@ -34,8 +34,8 @@ class NTPUserDataLogger
content::WebContents* content);
// Called when an event occurs on the NTP that requires a counter to be
- // incremented. |time| is the delta time in ms from navigation start until
- // this event happened.
+ // incremented. |time| is the delta time from navigation start until this
+ // event happened.
void LogEvent(NTPLoggingEventType event, base::TimeDelta time);
// Logs an impression on one of the NTP tiles by a given source.
@@ -50,12 +50,6 @@ class NTPUserDataLogger
private:
friend class content::WebContentsUserData<NTPUserDataLogger>;
- FRIEND_TEST_ALL_PREFIXES(SearchTabHelperTest,
- OnMostVisitedItemsChangedFromServer);
- FRIEND_TEST_ALL_PREFIXES(SearchTabHelperTest,
- OnMostVisitedItemsChangedFromClient);
- FRIEND_TEST_ALL_PREFIXES(NTPUserDataLoggerTest,
- TestLogging);
FRIEND_TEST_ALL_PREFIXES(NTPUserDataLoggerTest, TestLogMostVisitedImpression);
FRIEND_TEST_ALL_PREFIXES(NTPUserDataLoggerTest, TestNumberOfTiles);
« no previous file with comments | « chrome/browser/ui/search/search_ipc_router_unittest.cc ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698