Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2429523002: Cleanup desktop NTP metrics recording (Closed)

Created:
4 years, 2 months ago by Marc Treib
Modified:
4 years, 1 month ago
Reviewers:
sfiera
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, ntp-dev+reviews_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, pedrosimonetti+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup desktop NTP metrics recording - Remove all logging code from the multi-iframe NTP - Remove NTPLoggingEventType.NTP_TILE, use NTP_*_SIDE_SUGGESTIONS instead - Other small cleanups BUG=656646 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a Cr-Commit-Position: refs/heads/master@{#427056}

Patch Set 1 #

Patch Set 2 : . #

Messages

Total messages: 9 (4 generated)
Marc Treib
PTAL!
4 years, 2 months ago (2016-10-18 09:45:06 UTC) #3
sfiera
LGTM
4 years, 1 month ago (2016-10-24 11:31:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429523002/20001
4 years, 1 month ago (2016-10-24 11:47:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 13:31:01 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 13:33:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a
Cr-Commit-Position: refs/heads/master@{#427056}

Powered by Google App Engine
This is Rietveld 408576698