Simplifying audio network adaptor by moving receiver frame length range to ctor.

webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc

Index: webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc b/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc
index 5343acebd8857f2f32f81483ab09a65d18979df2..3580142032fc04f9b008c2958737d0c95fc73b47 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc
@@ -142,7 +142,7 @@ ControllerManagerImpl::Config::~Config() = default;
 std::unique_ptr<ControllerManager> ControllerManagerImpl::Create(
     const std::string& config_string,
     size_t num_encoder_channels,
-    rtc::ArrayView<const int> encoder_frame_lengths_ms,
+    const std::vector<int>& encoder_frame_lengths_ms,

[kwiberg-webrtc, 2016/10/19 09:12:01]

Why did you make this change?

[minyue-webrtc, 2016/10/19 09:25:54]

Because it is easier to construct a vector at the current caller.

[kwiberg-webrtc, 2016/10/19 10:43:33]

Well, marginally---given an ArrayView av, you should be able to create a vector
like this:

  std::vector<int> v(av.cbegin(), av.cend());

The advantage of using ArrayView instead of const vector& for the function
argument is that you don't force the caller to hold the data in a vector. It can
be a vector, but also e.g. an array, or anything else that stores the elements
contiguously in memory.

[minyue-webrtc, 2016/10/21 08:26:29]

Ok. thanks, yes. I'd changed it back.

     size_t intial_channels_to_encode,
     int initial_frame_length_ms,
     int initial_bitrate_bps,