Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2429453002: libyuv: Disable signing for iOS (Closed)

Created:
4 years, 2 months ago by kjellander_chromium
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, fbarchard
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

libyuv: Disable signing for iOS GN is stricter when checking if there's a signing identity on the machine so it fails unless ios_enable_code_signing=false is set in gn args when building for ARM devices. BUG=chromium:652188 TBR=ehmaldonado@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/ded9582695d74387b613dcbcad04936bff12d88b

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
kjellander_chromium
4 years, 2 months ago (2016-10-17 12:06:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429453002/1
4 years, 2 months ago (2016-10-17 12:06:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/ded9582695d74387b613dcbcad04936bff12d88b
4 years, 2 months ago (2016-10-17 12:15:48 UTC) #6
ehmaldonado_chromium
4 years, 2 months ago (2016-10-17 14:25:44 UTC) #7
Message was sent while issue was closed.
On 2016/10/17 12:15:48, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/tools/build/+/ded9582695d74387b613...

LGTM

Powered by Google App Engine
This is Rietveld 408576698