Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2429433002:
Setting device authorization timeout to 2000 ms on MAC (Closed)
|
Created:
4 years, 2 months ago by o1ka Modified:
4 years, 2 months ago Reviewers:
tommi (sloooow) - chröme CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSetting device authorization timeout to 2000 ms on MAC
Since we don't know the exact situation with renderer hangs due to device
authorization timeout (https://bugs.chromium.org/p/chromium/issues/detail?id=649744), setting the timeout to accomodate
99.9% of all the authorization times
BUG=647498
Committed: https://crrev.com/fa7d7d9413d0e3324e25cdb8d67ed87cf7f94acd
Cr-Commit-Position: refs/heads/master@{#425709}
Patch Set 1 #
Total comments: 1
Patch Set 2 : fix for compile error #Messages
Total messages: 16 (11 generated)
Description was changed from ========== Setting device authorization timeout to 2000 ms on MAC Since we don't know the exact situation with renderer hangs due to device authorization timeout (issue 649744), setting the timeout to accomodate 99.9% of all the authorization times (https://uma.googleplex.com/p/chrome/histograms/?endDate=latest&dayCount=28&hi...) BUG=647498 ========== to ========== Setting device authorization timeout to 2000 ms on MAC Since we don't know the exact situation with renderer hangs due to device authorization timeout (issue 649744), setting the timeout to accomodate 99.9% of all the authorization times BUG=647498 ==========
Description was changed from ========== Setting device authorization timeout to 2000 ms on MAC Since we don't know the exact situation with renderer hangs due to device authorization timeout (issue 649744), setting the timeout to accomodate 99.9% of all the authorization times BUG=647498 ========== to ========== Setting device authorization timeout to 2000 ms on MAC Since we don't know the exact situation with renderer hangs due to device authorization timeout (https://bugs.chromium.org/p/chromium/issues/detail?id=649744), setting the timeout to accomodate 99.9% of all the authorization times BUG=647498 ==========
The CQ bit was checked by olka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
olka@chromium.org changed reviewers: + tommi@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
lgtm with the compilation error fixed https://codereview.chromium.org/2429433002/diff/1/content/renderer/media/audi... File content/renderer/media/audio_device_factory.cc (right): https://codereview.chromium.org/2429433002/diff/1/content/renderer/media/audi... content/renderer/media/audio_device_factory.cc:35: #elseif defined(OS_MACOSX) elif? or just 'else if'
The CQ bit was checked by olka@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org Link to the patchset: https://codereview.chromium.org/2429433002/#ps20001 (title: "fix for compile error")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Setting device authorization timeout to 2000 ms on MAC Since we don't know the exact situation with renderer hangs due to device authorization timeout (https://bugs.chromium.org/p/chromium/issues/detail?id=649744), setting the timeout to accomodate 99.9% of all the authorization times BUG=647498 ========== to ========== Setting device authorization timeout to 2000 ms on MAC Since we don't know the exact situation with renderer hangs due to device authorization timeout (https://bugs.chromium.org/p/chromium/issues/detail?id=649744), setting the timeout to accomodate 99.9% of all the authorization times BUG=647498 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Setting device authorization timeout to 2000 ms on MAC Since we don't know the exact situation with renderer hangs due to device authorization timeout (https://bugs.chromium.org/p/chromium/issues/detail?id=649744), setting the timeout to accomodate 99.9% of all the authorization times BUG=647498 ========== to ========== Setting device authorization timeout to 2000 ms on MAC Since we don't know the exact situation with renderer hangs due to device authorization timeout (https://bugs.chromium.org/p/chromium/issues/detail?id=649744), setting the timeout to accomodate 99.9% of all the authorization times BUG=647498 Committed: https://crrev.com/fa7d7d9413d0e3324e25cdb8d67ed87cf7f94acd Cr-Commit-Position: refs/heads/master@{#425709} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fa7d7d9413d0e3324e25cdb8d67ed87cf7f94acd Cr-Commit-Position: refs/heads/master@{#425709} |
