Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 24294003: [Telemetry] Move WPR archives and credentials from src-internal to Cloud Storage. (Closed)

Created:
7 years, 3 months ago by dtu
Modified:
7 years, 3 months ago
Reviewers:
nduca, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Move WPR archives and credentials from src-internal to Cloud Storage. - I uploaded the files already. They are in the bucket chrome-telemetry. - Removed the logic that uploads page set archive info files. Those are staying in the source tree. - Updated all references to use the new buckets. Moved the media files from chromium-wpr to chromium-telemetry. BUG=223667 TEST=./run_benchmark netsim -v; ./run_benchmark media -v; # You should see at least two "Downloading" lines at the beginning of each run. R=nduca@chromium.org, tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224507

Patch Set 1 #

Patch Set 2 : Add bear.webm #

Patch Set 3 : Fix up downloading code for WPR archives and credentials. #

Patch Set 4 : Unit test fixes and .gitignore #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1457 lines, -74 lines) Patch
M tools/perf/page_sets/2012Q3.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/PRESUBMIT.py View 3 chunks +6 lines, -2 lines 0 comments Download
M tools/perf/page_sets/calendar_forward_backward.json View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/.gitignore View 1 2 3 1 chunk +2 lines, -0 lines 2 comments Download
A tools/perf/page_sets/data/2012Q3.json View 1 chunk +226 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/2012Q3_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/calendar_forward_backward.json View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/calendar_forward_backward_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/credentials.json.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/debug_credentials.json.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/gmail_alt_threadlist_conversation.json View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/gmail_alt_threadlist_conversation_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/gmail_alt_two_labels.json View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/gmail_alt_two_labels_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/gmail_expand_collapse_conversation.json View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/gmail_expand_collapse_conversation_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/intl_ar_fa_he.json View 1 chunk +18 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/intl_ar_fa_he_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/intl_es_fr_pt-BR.json View 1 chunk +18 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/intl_es_fr_pt-BR_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/intl_hi_ru.json View 1 chunk +19 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/intl_hi_ru_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/intl_ja_zh.json View 1 chunk +27 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/intl_ja_zh_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/intl_ko_th_vi.json View 1 chunk +21 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/intl_ko_th_vi_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/jsgamebench.json View 1 chunk +10 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/jsgamebench_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/key_desktop_sites.json View 1 chunk +718 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/key_mobile_sites.json View 1 chunk +59 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/key_mobile_sites_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/key_mobile_sites_001.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/key_mobile_sites_002.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/key_mobile_sites_003.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/key_mobile_sites_004.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/kraken.json View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/kraken_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/pica.json View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/pica_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/plus_alt_posts_photos.json View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/plus_alt_posts_photos_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/robohornetpro.json View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/robohornetpro_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/test.json View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/test_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/top_10.json View 1 chunk +18 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/top_10_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/top_25.json View 1 chunk +35 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/top_25_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/top_25_001.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/tough_canvas_cases.json View 1 chunk +33 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/tough_canvas_cases_001.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/tough_layout_cases.json View 1 chunk +20 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/tough_layout_cases_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/tough_layout_cases_001.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/typical_25.json View 1 chunk +33 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/typical_25_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/gmail_alt_threadlist_conversation.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/gmail_alt_two_labels.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/gmail_expand_collapse_conversation.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/intl_ar_fa_he.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/intl_es_fr_pt-BR.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/intl_hi_ru.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/intl_ja_zh.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/intl_ko_th_vi.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_desktop_sites.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/mobile_memory.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/pica.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/plus_alt_posts_photos.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_10.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_25.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_canvas_cases.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_layout_cases.json View 1 chunk +2 lines, -2 lines 0 comments Download
D tools/perf/page_sets/tough_video_cases/bear.webm View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/perf/page_sets/tough_video_cases/bear.webm.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/typical_25.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/cloud_storage.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 1 2 3 1 chunk +33 lines, -24 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info.py View 1 2 6 chunks +15 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info_unittest.py View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dtu
7 years, 3 months ago (2013-09-20 06:56:16 UTC) #1
nduca
lgtm
7 years, 3 months ago (2013-09-20 13:05:20 UTC) #2
tonyg
Wonderful! lgtm https://codereview.chromium.org/24294003/diff/10001/tools/perf/page_sets/data/.gitignore File tools/perf/page_sets/data/.gitignore (right): https://codereview.chromium.org/24294003/diff/10001/tools/perf/page_sets/data/.gitignore#newcode1 tools/perf/page_sets/data/.gitignore:1: credentials.json This .gitignore doesn't seem like a ...
7 years, 3 months ago (2013-09-20 14:46:16 UTC) #3
dtu
https://chromiumcodereview.appspot.com/24294003/diff/10001/tools/perf/page_sets/data/.gitignore File tools/perf/page_sets/data/.gitignore (right): https://chromiumcodereview.appspot.com/24294003/diff/10001/tools/perf/page_sets/data/.gitignore#newcode1 tools/perf/page_sets/data/.gitignore:1: credentials.json On 2013/09/20 14:46:17, tonyg wrote: > This .gitignore ...
7 years, 3 months ago (2013-09-20 17:26:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/24294003/10001
7 years, 3 months ago (2013-09-20 18:06:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=200318
7 years, 3 months ago (2013-09-20 21:37:54 UTC) #6
dtu
7 years, 3 months ago (2013-09-20 22:49:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r224507 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698