Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

Issue 2429343004: [CachedAccessor] for window.document. (Closed)
Patch Set: Fix expectation for global-interface-listing-expected, windows. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
index 7baf69ad8dde4cec348ac5c5a2fb4c13d1be775e..a36563ef24757661e63abcabf413ff9b5603d0b8 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
@@ -63,6 +63,8 @@ class CORE_EXPORT V8DOMConfiguration final {
DoNotCheckHolder,
};
+ typedef v8::Local<v8::Private> (*CachedAccessorCallback)(v8::Isolate*);
+
// AttributeConfiguration translates into calls to SetNativeDataProperty() on
// either the instance or the prototype ObjectTemplate, based on
// |instanceOrPrototypeConfiguration|.
@@ -74,6 +76,10 @@ class CORE_EXPORT V8DOMConfiguration final {
v8::AccessorNameSetterCallback setter;
v8::AccessorNameGetterCallback getterForMainWorld;
v8::AccessorNameSetterCallback setterForMainWorld;
+ // TODO(vogelheim): This has to be removed too since it's only used in
+ // accessors.
+ // The accessor's 'result' is stored in a private property.
+ CachedAccessorCallback cachedAccessorCallback;
const WrapperTypeInfo* data;
unsigned settings : 8; // v8::AccessControl
unsigned attribute : 8; // v8::PropertyAttribute
@@ -126,6 +132,8 @@ class CORE_EXPORT V8DOMConfiguration final {
v8::FunctionCallback setter;
v8::FunctionCallback getterForMainWorld;
v8::FunctionCallback setterForMainWorld;
+ // The accessor's 'result' is stored in a private property.
+ CachedAccessorCallback cachedAccessorCallback;
const WrapperTypeInfo* data;
unsigned settings : 8; // v8::AccessControl
unsigned attribute : 8; // v8::PropertyAttribute

Powered by Google App Engine
This is Rietveld 408576698