Desktop NTP metrics: Use ntp_tiles::metrics:: functions

components/ntp_tiles/most_visited_sites.cc

Index: components/ntp_tiles/most_visited_sites.cc
diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc
index 3eb145841396fa2d400fbcc5a256f117a1dc7bec..fab0384830af66c9f4734e5eaff4f07c9ae6be3a 100644
--- a/components/ntp_tiles/most_visited_sites.cc
+++ b/components/ntp_tiles/most_visited_sites.cc
@@ -398,7 +398,11 @@ NTPTilesVector MostVisitedSites::MergeTiles(NTPTilesVector personal_tiles,
 void MostVisitedSites::NotifyMostVisitedURLsObserver() {
   if (!waiting_for_most_visited_sites_ && !waiting_for_popular_sites_ &&
       !recorded_impressions_) {
-    metrics::RecordImpressions(current_tiles_);
+    // TODO(treib): Move this out of here. crbug.com/514752
+    int num_tiles = static_cast<int>(current_tiles_.size());

[sfiera, 2016/10/25 12:12:11]

Why not "size_t num_tiles", "size_t i"?

[Marc Treib, 2016/10/25 12:23:39]

Then I'll have to cast below, since RecordTileImpression wants an int for the
index (as it should IMO - we don't generally use size_t or unsigned types in
general).

+    for (int i = 0; i < num_tiles; i++)
+      metrics::RecordTileImpression(i, current_tiles_[i].source);
+    metrics::RecordPageImpression(num_tiles);
     recorded_impressions_ = true;
   }