Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2429243003: Provide an extensible form of ToSourceVisitor (issue 27169) (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
matanl, matan
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Provide an extensible form of ToSourceVisitor (issue 27169) R=matan@lurey.org Committed: https://github.com/dart-lang/sdk/commit/b3f66b03a1627935feb1b95c83b1e6738416498a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3399 lines, -6 lines) Patch
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 2 chunks +1161 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 3 chunks +2238 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Brian Wilkerson
Rather than change the original class, I copied it, made the private methods visible (and ...
4 years, 2 months ago (2016-10-19 21:23:10 UTC) #2
matan
lgtm
4 years, 2 months ago (2016-10-19 21:30:33 UTC) #5
matan
lgtm
4 years, 2 months ago (2016-10-19 21:30:35 UTC) #6
Brian Wilkerson
4 years, 2 months ago (2016-10-19 21:31:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b3f66b03a1627935feb1b95c83b1e6738416498a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698