Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: services/ui/public/cpp/window.h

Issue 2429173005: Mus+Ash: Replace (Server)WindowSurface with (Server)WindowCompositorFrameSink (Closed)
Patch Set: ui::CompositorFrameSink => ui::WindowCompositorFrameSink Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/public/cpp/window.h
diff --git a/services/ui/public/cpp/window.h b/services/ui/public/cpp/window.h
index 433e619e82bffe67cae1943c387b85761666a44b..fe65f7ac8a02556ed6aee9c63f62c47263b1e8dc 100644
--- a/services/ui/public/cpp/window.h
+++ b/services/ui/public/cpp/window.h
@@ -14,8 +14,8 @@
#include "mojo/public/cpp/bindings/array.h"
#include "services/service_manager/public/interfaces/interface_provider.mojom.h"
#include "services/ui/common/types.h"
-#include "services/ui/public/cpp/compositor_frame_sink.h"
#include "services/ui/public/cpp/surface_id_handler.h"
+#include "services/ui/public/cpp/window_compositor_frame_sink.h"
#include "services/ui/public/interfaces/mus_constants.mojom.h"
#include "services/ui/public/interfaces/window_tree.mojom.h"
#include "ui/gfx/geometry/insets.h"
@@ -32,7 +32,7 @@ class ServiceProviderImpl;
class SurfaceIdHandler;
class WindowObserver;
class WindowSurface;
-class WindowSurfaceBinding;
+class WindowCompositorFrameSinkBinding;
rjkroege 2016/10/20 22:22:18 these need to be in alphabetical order
Fady Samuel 2016/10/21 20:53:27 Done.
class WindowDropTarget;
class WindowTreeClient;
class WindowTreeClientPrivate;
@@ -115,13 +115,14 @@ class Window {
// Window is attached to the root.
bool IsDrawn() const;
- std::unique_ptr<CompositorFrameSink> RequestCompositorFrameSink(
- mojom::SurfaceType type,
+ std::unique_ptr<WindowCompositorFrameSink> RequestCompositorFrameSink(
+ mojom::CompositorFrameSinkType type,
scoped_refptr<cc::ContextProvider> context_provider);
void AttachCompositorFrameSink(
- mojom::SurfaceType type,
- std::unique_ptr<WindowSurfaceBinding> surface_binding);
+ mojom::CompositorFrameSinkType type,
+ std::unique_ptr<WindowCompositorFrameSinkBinding>
+ compositor_frame_sink_binding);
// The template-ized versions of the following methods rely on the presence
// of a mojo::TypeConverter<const std::vector<uint8_t>, T>.

Powered by Google App Engine
This is Rietveld 408576698