Issue 242903002: ASSERTION FAILED: x2 >= x1 in WebCore::RenderObject::drawSolidBoxSide

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 242903002: ASSERTION FAILED: x2 >= x1 in WebCore::RenderObject::drawSolidBoxSide (Closed)

Created:
6 years, 8 months ago by reni

Modified:
6 years, 8 months ago

Reviewers:
Stephen Chennney, pdr.

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

ASSERTION FAILED: x2 >= x1 in WebCore::RenderObject::drawSolidBoxSide In some cases when a negative margin and a positive padding are applied together to the right and/or left side of the box, the logical width of the borders can be set to a negative value, making the assertion fire. The fix checks if the width or height of the box is negative, and if so, it will not display the borders and shadows of the box. This is a backport from WebKit r167351. Patch by Martin Hodovan and reviewed by Darin Adler. R=schenney@chromium.org BUG=364797 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171987

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -0 lines)			Patch
A	LayoutTests/fast/css/padding-margin-negative-border.html	View	1 chunk	+67 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css/padding-margin-negative-border-expected.html	View	1 chunk	+70 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBoxModelObject.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/242903002/1

6 years, 8 months ago (2014-04-18 23:25:50 UTC) #4

Message was sent while issue was closed.

Change committed as 171987

Expand Messages | Collapse Messages