Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2428963002: Fix list marker paint invalidation on move (Closed)

Created:
4 years, 2 months ago by Xianzhu
Modified:
4 years, 2 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix list marker paint invalidation on move BUG=655941 TEST=paint/invalidation/list-marker-move.html Committed: https://crrev.com/5ab22dff550158922f4a443d86cf993ac46348f8 Cr-Commit-Position: refs/heads/master@{#426074}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebaseline #

Messages

Total messages: 21 (13 generated)
Xianzhu
4 years, 2 months ago (2016-10-18 16:52:01 UTC) #4
chrishtr
https://chromiumcodereview.appspot.com/2428963002/diff/1/third_party/WebKit/Source/core/layout/LayoutListMarker.h File third_party/WebKit/Source/core/layout/LayoutListMarker.h (right): https://chromiumcodereview.appspot.com/2428963002/diff/1/third_party/WebKit/Source/core/layout/LayoutListMarker.h#newcode108 third_party/WebKit/Source/core/layout/LayoutListMarker.h:108: bool paintedOutputOfObjectHasNoEffectRegardlessOfSize() const override { Is this the only ...
4 years, 2 months ago (2016-10-18 18:33:34 UTC) #7
Xianzhu
https://chromiumcodereview.appspot.com/2428963002/diff/1/third_party/WebKit/Source/core/layout/LayoutListMarker.h File third_party/WebKit/Source/core/layout/LayoutListMarker.h (right): https://chromiumcodereview.appspot.com/2428963002/diff/1/third_party/WebKit/Source/core/layout/LayoutListMarker.h#newcode108 third_party/WebKit/Source/core/layout/LayoutListMarker.h:108: bool paintedOutputOfObjectHasNoEffectRegardlessOfSize() const override { On 2016/10/18 18:33:34, chrishtr ...
4 years, 2 months ago (2016-10-18 18:47:04 UTC) #8
chrishtr
lgtm
4 years, 2 months ago (2016-10-18 18:50:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428963002/1
4 years, 2 months ago (2016-10-18 18:51:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428963002/20001
4 years, 2 months ago (2016-10-18 21:03:14 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 22:51:39 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:04:13 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ab22dff550158922f4a443d86cf993ac46348f8
Cr-Commit-Position: refs/heads/master@{#426074}

Powered by Google App Engine
This is Rietveld 408576698