Helper function for get interactive timestamps

Helper function for get interactive timestamps

To compute Estimated Input Latency, we need to identify task windows after a
page becomes interactive and until the user navigates away from the page. When a
page becomes interactive is defined by the TTI metric. This CL adds a function
to extract all interactive timestamps of a single renderer.

BUG=chromium:631206
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f2c0fd71e5d2ada5b38ed1a2b1baecd0f7486b4a

[dproy, 2016-10-18 16:34:32]

Description was changed from

==========
Helper function for get interactive timestamps

BUG=chromium:631206
==========

to

==========
Helper function for get interactive timestamps

To compute Estimated Input Latency, we need to identify task windows after a
page becomes interactive and until the user navigates away from the page. When a
page becomes interactive is defined by the TTI metric. This CL adds a function
to extract all interactive timestamps of a single renderer.

BUG=chromium:631206
==========

[dproy, 2016-10-18 16:34:32]

dproy@chromium.org changed reviewers:
+ benjhayden@chromium.org, charliea@chromium.org, nednguyen@google.com,
tdresser@chromium.org

[dproy, 2016-10-18 16:37:22]

PTAL. Split from https://codereview.chromium.org/2323533003/

@benjhayden: Do you think the layering is ok? Currently this file in
extras/chrome is depending on metrics/loading_metric.

[benjhayden, 2016-10-18 19:54:05]

lgtm

[nednguyen, 2016-10-18 19:56:12]

https://codereview.chromium.org/2428953002/diff/1/tracing/tracing/extras/chro...
File tracing/tracing/extras/chrome/estimated_input_latency.html (right):

https://codereview.chromium.org/2428953002/diff/1/tracing/tracing/extras/chro...
tracing/tracing/extras/chrome/estimated_input_latency.html:50: return
interactiveTimestamps;
Hmhh, this is a flatten list, which will not work well for the cases of multi
tabs. Shouldn't you return a dict, with the key is renderer pid & value is a
list of interactiveTimeStamps?

That would make the transition from the hacky version of loadingMetric to the
official version easier..

[dproy, 2016-10-18 20:45:00]

https://codereview.chromium.org/2428953002/diff/1/tracing/tracing/extras/chro...
File tracing/tracing/extras/chrome/estimated_input_latency.html (right):

https://codereview.chromium.org/2428953002/diff/1/tracing/tracing/extras/chro...
tracing/tracing/extras/chrome/estimated_input_latency.html:50: return
interactiveTimestamps;
On 2016/10/18 19:56:11, nednguyen wrote:
> Hmhh, this is a flatten list, which will not work well for the cases of multi
> tabs. Shouldn't you return a dict, with the key is renderer pid & value is a
> list of interactiveTimeStamps?
> 
> That would make the transition from the hacky version of loadingMetric to the
> official version easier..

You're right. Fixed in latest patch.

[nednguyen, 2016-10-18 23:08:50]

lgtm

[charliea (OOO until 10-5), 2016-10-18 23:27:54]

lgtm w/ comments

https://codereview.chromium.org/2428953002/diff/20001/tracing/tracing/extras/...
File tracing/tracing/extras/chrome/estimated_input_latency_test.html (right):

https://codereview.chromium.org/2428953002/diff/20001/tracing/tracing/extras/...
tracing/tracing/extras/chrome/estimated_input_latency_test.html:58:
{isLoadingMainFrame: true, frame: {id_ref: '0xdeadbeef'},
this this should be:

'ptr', 'loading', 'FrameLoader', 300, {
  isLoadingMainFrame: true,
  frame: {id_ref: '0xdeadbeef'},
  documentLoaderUrl: 'http://example.com
});

https://codereview.chromium.org/2428953002/diff/20001/tracing/tracing/extras/...
tracing/tracing/extras/chrome/estimated_input_latency_test.html:141:
interactiveTimestamps.sort((a, b) => a - b), [5000, 110000]);
think this is default sort fn

https://codereview.chromium.org/2428953002/diff/20001/tracing/tracing/extras/...
tracing/tracing/extras/chrome/estimated_input_latency_test.html:164:
interactiveTimestamps.sort((a, b) => a - b),
same

[dproy, 2016-10-18 23:38:57]

https://codereview.chromium.org/2428953002/diff/20001/tracing/tracing/extras/...
File tracing/tracing/extras/chrome/estimated_input_latency_test.html (right):

https://codereview.chromium.org/2428953002/diff/20001/tracing/tracing/extras/...
tracing/tracing/extras/chrome/estimated_input_latency_test.html:58:
{isLoadingMainFrame: true, frame: {id_ref: '0xdeadbeef'},
On 2016/10/18 23:27:54, charliea wrote:
> this this should be:
> 
> 'ptr', 'loading', 'FrameLoader', 300, {
>   isLoadingMainFrame: true,
>   frame: {id_ref: '0xdeadbeef'},
>   documentLoaderUrl: 'http://example.com
> });

Done.

https://codereview.chromium.org/2428953002/diff/20001/tracing/tracing/extras/...
tracing/tracing/extras/chrome/estimated_input_latency_test.html:141:
interactiveTimestamps.sort((a, b) => a - b), [5000, 110000]);
On 2016/10/18 23:27:53, charliea wrote:
> think this is default sort fn
I was surprised to learn it's not:
http://stackoverflow.com/questions/1063007/how-to-sort-an-array-of-integers-c...

[charliea (OOO until 10-5), 2016-10-18 23:48:20]

https://codereview.chromium.org/2428953002/diff/20001/tracing/tracing/extras/...
File tracing/tracing/extras/chrome/estimated_input_latency_test.html (right):

https://codereview.chromium.org/2428953002/diff/20001/tracing/tracing/extras/...
tracing/tracing/extras/chrome/estimated_input_latency_test.html:141:
interactiveTimestamps.sort((a, b) => a - b), [5000, 110000]);
On 2016/10/18 23:38:57, dproy wrote:
> On 2016/10/18 23:27:53, charliea wrote:
> > think this is default sort fn
> I was surprised to learn it's not:
>
http://stackoverflow.com/questions/1063007/how-to-sort-an-array-of-integers-c...

Welp, that's the dumbest thing I've seen today.

[tdresser, 2016-10-19 14:55:33]

LGTM

[dproy, 2016-10-19 14:57:46]

The CQ bit was checked by dproy@chromium.org

[dproy, 2016-10-19 14:57:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjhayden@chromium.org, nednguyen@google.com, charliea@chromium.org
Link to the patchset: https://codereview.chromium.org/2428953002/#ps40001
(title: "Address charliea@ comments")

[commit-bot: I haz the power, 2016-10-19 14:57:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 15:49:36]

Description was changed from

==========
Helper function for get interactive timestamps

To compute Estimated Input Latency, we need to identify task windows after a
page becomes interactive and until the user navigates away from the page. When a
page becomes interactive is defined by the TTI metric. This CL adds a function
to extract all interactive timestamps of a single renderer.

BUG=chromium:631206
==========

to

==========
Helper function for get interactive timestamps

To compute Estimated Input Latency, we need to identify task windows after a
page becomes interactive and until the user navigates away from the page. When a
page becomes interactive is defined by the TTI metric. This CL adds a function
to extract all interactive timestamps of a single renderer.

BUG=chromium:631206

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-10-19 15:49:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...