Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2428893002: Fix typo in --manually_grab_svn_rev deprecated flag. (Closed)

Created:
4 years, 2 months ago by sdefresne
Modified:
4 years, 2 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix typo in --manually_grab_svn_rev deprecated flag. Chrome on iOS downstream bot still use that flag and they cannot recover as the flag has been misspelt when resurrected. TBR=agable@chromium.org TBR=dnj@chromium.org BUG=656865 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/69b1be10a44289cca2bbb1de51605ec28808dea0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gclient.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428893002/1
4 years, 2 months ago (2016-10-18 12:40:48 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-18 12:40:51 UTC) #6
Paweł Hajdan Jr.
LGTM
4 years, 2 months ago (2016-10-18 12:44:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428893002/1
4 years, 2 months ago (2016-10-18 12:45:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/69b1be10a44289cca2bbb1de51605ec28808dea0
4 years, 2 months ago (2016-10-18 12:48:06 UTC) #12
agable
4 years, 2 months ago (2016-10-18 16:32:42 UTC) #13
Message was sent while issue was closed.
Thanks for the quick fix, and sorry for the breakage. LGTM.

Powered by Google App Engine
This is Rietveld 408576698