Source/core/css/MediaValuesDynamic.h - Issue 242883002: Remove MediaValues' dependency on RenderStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaValuesDynamic.h

Issue 242883002: Remove MediaValues' dependency on RenderStyle (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed review comments. Removed style from MediaQueryEvaluator. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaValuesDynamic.h

diff --git a/Source/core/css/MediaValuesDynamic.h b/Source/core/css/MediaValuesDynamic.h

index d10fe9a0337f6358e190b962bc30ac3ed2d57ffe..e22df3ee74c42c421cb65f7635f808273797eb4f 100644

--- a/Source/core/css/MediaValuesDynamic.h

+++ b/Source/core/css/MediaValuesDynamic.h

@@ -13,8 +13,7 @@ class Document;

class MediaValuesDynamic FINAL : public MediaValues {

public:

- static PassRefPtr<MediaValues> create(Document&);

- static PassRefPtr<MediaValues> create(PassRefPtr<LocalFrame>, PassRefPtr<RenderStyle>);

+ static PassRefPtr<MediaValues> create(PassRefPtr<LocalFrame>);

virtual PassRefPtr<MediaValues> copy() const OVERRIDE;

virtual bool isSafeToSendToAnotherThread() const OVERRIDE;

virtual bool computeLength(double value, unsigned short type, int& result) const OVERRIDE;

@@ -36,9 +35,8 @@ public:

virtual bool hasValues() const OVERRIDE;

protected:

- MediaValuesDynamic(PassRefPtr<LocalFrame>, PassRefPtr<RenderStyle>);

+ MediaValuesDynamic(PassRefPtr<LocalFrame>);

- RefPtr<RenderStyle> m_style;

RefPtr<LocalFrame> m_frame;

};