Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2428803002: Don't send loading completion callbacks for detaching frames. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index 952033b193dd247a3ab135a68ec8b922a11c3caa..581fcd37d9fcd029a74f354d4976cbe07c8db29d 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -947,10 +947,6 @@ void PasswordAutofillAgent::SendPasswordForms(bool only_visible) {
}
blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
- // RenderFrameObserver::DidFinishLoad() can fire when Frame is
- // detaching. crbug.com/654654
- if (frame->isFrameDetachedForSpecialOneOffStopTheCrashingHackBug561873())
- return;
// Make sure that this security origin is allowed to use password manager.
blink::WebSecurityOrigin origin = frame->document().getSecurityOrigin();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | third_party/WebKit/public/web/WebLocalFrame.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698