Use different unique identifier for a fallback family.

Use different unique identifier for a fallback family.

BUG=chromium:266412
R=mtklein@google.com, reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11451

[Xianzhu, 2013-09-19 19:07:25]

https://chromiumcodereview.appspot.com/24288002/diff/1/src/ports/SkFontConfig...
File src/ports/SkFontConfigInterface_android.cpp (right):

https://chromiumcodereview.appspot.com/24288002/diff/1/src/ports/SkFontConfig...
src/ports/SkFontConfigInterface_android.cpp:288: if (familyRec &&
!familyRec->fIsFallbackFont) {
This condition can be removed.

[reed1, 2013-09-19 20:24:37]

lgtm

[mtklein, 2013-09-20 18:53:38]

lgtm, with some suggestions

https://chromiumcodereview.appspot.com/24288002/diff/6001/src/ports/SkFontCon...
File src/ports/SkFontConfigInterface_android.cpp (right):

https://chromiumcodereview.appspot.com/24288002/diff/6001/src/ports/SkFontCon...
src/ports/SkFontConfigInterface_android.cpp:285: addFallbackFamily(familyRecID);
Can you add a note here that this calls insert_into_name_dict for us?  Hard to
tell without jumping around.

https://chromiumcodereview.appspot.com/24288002/diff/6001/src/ports/SkFontCon...
src/ports/SkFontConfigInterface_android.cpp:344: // identifier that we've chosen
is the familyID in hex.
Can you add an e.g. here?  I was wondering what exactly %.2x does in a case like
this.

[djsollen, 2013-09-24 20:08:56]

Committed patchset #3 manually as r11451 (presubmit successful).