Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 2428793002: Test usage of registered custom properties in custom paint (Closed)

Created:
4 years, 2 months ago by Timothy Loh
Modified:
4 years, 2 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test usage of registered custom properties in custom paint This patch adds tests for reading registered custom properties of types <length> and <number> via custom paint. BUG=641877 Committed: https://crrev.com/647f07fb29ed0e52b09af26a537849f7f4ce8c48 Cr-Commit-Position: refs/heads/master@{#425982}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
Timothy Loh
Adding tests for stuff that's worked for a while. Not sure if the image urls ...
4 years, 2 months ago (2016-10-18 05:00:58 UTC) #4
ikilpatrick
lgtm, looks great \o/
4 years, 2 months ago (2016-10-18 16:07:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428793002/1
4 years, 2 months ago (2016-10-18 16:08:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 16:13:56 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 16:17:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/647f07fb29ed0e52b09af26a537849f7f4ce8c48
Cr-Commit-Position: refs/heads/master@{#425982}

Powered by Google App Engine
This is Rietveld 408576698