Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 2428753003: Revert of ServiceWorker: Add CHECK to EmbeddedWorkerRegistry for debug (Closed)

Created:
4 years, 2 months ago by nhiroki
Modified:
4 years, 2 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ServiceWorker: Add CHECK to EmbeddedWorkerRegistry for debug (patchset #2 id:20001 of https://codereview.chromium.org/2353853002/ ) Reason for revert: We've collected enough information for debug. Original issue's description: > ServiceWorker: Add CHECK to EmbeddedWorkerRegistry for debug > > BUG=648477 > > Committed: https://crrev.com/9ea783ee0201e243384f98dc38f101e4bed5c8ca > Cr-Commit-Position: refs/heads/master@{#419681} TBR=falken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=648477 Committed: https://crrev.com/8742eeafea4463186cef5da6b5e64b0b8b0582df Cr-Commit-Position: refs/heads/master@{#425892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/browser/service_worker/embedded_worker_registry.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nhiroki
Created Revert of ServiceWorker: Add CHECK to EmbeddedWorkerRegistry for debug
4 years, 2 months ago (2016-10-18 03:31:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428753003/1
4 years, 2 months ago (2016-10-18 03:32:00 UTC) #3
falken
lgtm
4 years, 2 months ago (2016-10-18 03:46:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 05:53:12 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 05:55:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8742eeafea4463186cef5da6b5e64b0b8b0582df
Cr-Commit-Position: refs/heads/master@{#425892}

Powered by Google App Engine
This is Rietveld 408576698