ImageCapture content_browsertests: bugfix flag passing

ImageCapture content_browsertests: bugfix flag passing

Switches under |kEnableBlinkFeatures| shoud be passed as
comma separated, but they are separated on ToT: the last
one would override the others. (Probably that's part of
the reasons these tests have been troublesome). This CL
solves that.

Also, this CL removes the superfluous 'CreateAnd'
test name prefix.

BUG=656810
Committed: https://crrev.com/b084f6a7f231d2458a0c43e371cfe82dafbed7a4
Cr-Commit-Position: refs/heads/master@{#425833}

[mcasas, 2016-10-17 23:03:18]

Description was changed from

==========
ImageCapture content_browsertests: bugfix flag passing



BUG=656810
==========

to

==========
ImageCapture content_browsertests: bugfix flag passing

Switches under |kEnableBlinkFeatures| shoud be passed as
comma separated, and now they are separated: the last
one would override the others. Probably that's part of
the reasons these tests have been troublesome.

Also, this CL removes the superfluous 'CreateAnd'
test name prefix.

BUG=656810
==========

[mcasas, 2016-10-17 23:03:51]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 23:04:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-10-17 23:10:33]

Description was changed from

==========
ImageCapture content_browsertests: bugfix flag passing

Switches under |kEnableBlinkFeatures| shoud be passed as
comma separated, and now they are separated: the last
one would override the others. Probably that's part of
the reasons these tests have been troublesome.

Also, this CL removes the superfluous 'CreateAnd'
test name prefix.

BUG=656810
==========

to

==========
ImageCapture content_browsertests: bugfix flag passing

Switches under |kEnableBlinkFeatures| shoud be passed as
comma separated, but they are separated on ToT: the last
one would override the others. (Probably that's part of
the reasons these tests have been troublesome). This CL
solves that.

Also, this CL removes the superfluous 'CreateAnd'
test name prefix.

BUG=656810
==========

[mcasas, 2016-10-17 23:11:02]

mcasas@chromium.org changed reviewers:
+ nick@chromium.org

[mcasas, 2016-10-17 23:11:02]

nick@ plz RS (trivial changes) or PTAL

[ncarter (slow), 2016-10-17 23:20:14]

lgtm

https://codereview.chromium.org/2428753002/diff/1/content/browser/webrtc/webr...
File content/browser/webrtc/webrtc_image_capture_browsertest.cc (right):

https://codereview.chromium.org/2428753002/diff/1/content/browser/webrtc/webr...
content/browser/webrtc/webrtc_image_capture_browsertest.cc:112:
ASSERT_TRUE(RunImageCaptureTestCase("testCreateAndGetCapabilities()"));
Do you want to rename the js methods too?

[mcasas, 2016-10-17 23:22:05]

https://codereview.chromium.org/2428753002/diff/1/content/browser/webrtc/webr...
File content/browser/webrtc/webrtc_image_capture_browsertest.cc (right):

https://codereview.chromium.org/2428753002/diff/1/content/browser/webrtc/webr...
content/browser/webrtc/webrtc_image_capture_browsertest.cc:112:
ASSERT_TRUE(RunImageCaptureTestCase("testCreateAndGetCapabilities()"));
On 2016/10/17 23:20:13, ncarter wrote:
> Do you want to rename the js methods too?

Nah, I like the test cases to be called after what
they test, but the JS methods after what they do,
so: not worth renaming them in this patch.

[mcasas, 2016-10-18 00:24:04]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2016-10-18 00:24:05]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-10-18 00:24:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 00:30:22]

Description was changed from

==========
ImageCapture content_browsertests: bugfix flag passing

Switches under |kEnableBlinkFeatures| shoud be passed as
comma separated, but they are separated on ToT: the last
one would override the others. (Probably that's part of
the reasons these tests have been troublesome). This CL
solves that.

Also, this CL removes the superfluous 'CreateAnd'
test name prefix.

BUG=656810
==========

to

==========
ImageCapture content_browsertests: bugfix flag passing

Switches under |kEnableBlinkFeatures| shoud be passed as
comma separated, but they are separated on ToT: the last
one would override the others. (Probably that's part of
the reasons these tests have been troublesome). This CL
solves that.

Also, this CL removes the superfluous 'CreateAnd'
test name prefix.

BUG=656810
==========

[commit-bot: I haz the power, 2016-10-18 00:30:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-18 00:33:09]

Description was changed from

==========
ImageCapture content_browsertests: bugfix flag passing

Switches under |kEnableBlinkFeatures| shoud be passed as
comma separated, but they are separated on ToT: the last
one would override the others. (Probably that's part of
the reasons these tests have been troublesome). This CL
solves that.

Also, this CL removes the superfluous 'CreateAnd'
test name prefix.

BUG=656810
==========

to

==========
ImageCapture content_browsertests: bugfix flag passing

Switches under |kEnableBlinkFeatures| shoud be passed as
comma separated, but they are separated on ToT: the last
one would override the others. (Probably that's part of
the reasons these tests have been troublesome). This CL
solves that.

Also, this CL removes the superfluous 'CreateAnd'
test name prefix.

BUG=656810

Committed: https://crrev.com/b084f6a7f231d2458a0c43e371cfe82dafbed7a4
Cr-Commit-Position: refs/heads/master@{#425833}
==========

[commit-bot: I haz the power, 2016-10-18 00:33:10]

Patchset 1 (id:??) landed as
https://crrev.com/b084f6a7f231d2458a0c43e371cfe82dafbed7a4
Cr-Commit-Position: refs/heads/master@{#425833}