MD Settings: Migrating autofill cr-shared-menu to settings-action-menu.

chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

Index: chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js b/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
index c3b7c61709c473fd0be4ff80b524b1efbc405276..1bbe7a375f590f55c4df3a033000689b12f2e4a9 100644
--- a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
@@ -9,8 +9,7 @@ var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
 GEN_INCLUDE([
-    ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js',
-    ROOT_PATH + 'ui/webui/resources/js/load_time_data.js',

[dpapad, 2016/10/18 00:16:50]

settings_action_menu.html depends on direction_delagate.html, which depends on
i18n_setup.html, which loads loadTimeData. So I had to remove this line
otherwise I get the following error

Unexpected condition on
chrome://md-settings/passwords_and_forms_page/autofill_section.html: should only
include this file once.

+  ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js',
 ]);
 
 /**
@@ -24,9 +23,9 @@ CountryDetailManagerTestImpl.prototype = {
   getCountryList: function() {
     return new Promise(function(resolve) {
       resolve([
-          {name: 'United States', countryCode: 'US'},  // Default test country.
-          {name: 'Israel', countryCode: 'IL'},
-          {name: 'United Kingdom', countryCode: 'GB'},
+        {name: 'United States', countryCode: 'US'},  // Default test country.
+        {name: 'Israel', countryCode: 'IL'},
+        {name: 'United Kingdom', countryCode: 'GB'},
       ]);
     });
   },
@@ -47,7 +46,7 @@ CountryDetailManagerTestImpl.prototype = {
  * @return {!Promise}
  */
 function asyncForEach(items, loopBody) {
-  return new Promise(function(finish) {
+  return new Promise(function(resolve) {
     var index = 0;
 
     function loop() {
@@ -55,7 +54,7 @@ function asyncForEach(items, loopBody) {
       if (item)
         loopBody(item).then(loop);
       else
-        finish();
+        resolve();
     };
 
     loop();
@@ -122,9 +121,6 @@ SettingsAutofillSectionBrowserTest.prototype = {
     // Test is run on an individual element that won't have a page language.
     this.accessibilityAuditConfig.auditRulesToIgnore.push('humanLangMissing');
 
-    // Faking 'strings.js' for this test.
-    loadTimeData.data = this.i18nStrings;

[dpapad, 2016/10/18 00:16:50]

This line started causing me problems, because loadTimeData was already
populated at the time this was called, triggering the assertion at
https://cs.chromium.org/chromium/src/ui/webui/resources/js/load_time_data.js?....
I don't think this is needed at all though (tests pass even without it, since
those i18n strings are already in loadTimeData.

-
     settings.address.CountryDetailManagerImpl.instance_ =
         new CountryDetailManagerTestImpl();
   },