MD Settings: Migrating autofill cr-shared-menu to settings-action-menu.

chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Runs the Polymer Autofill Settings tests. */
 
 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
 GEN_INCLUDE([
-    ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js',
-    ROOT_PATH + 'ui/webui/resources/js/load_time_data.js',

[dpapad, 2016/10/18 00:16:50]

settings_action_menu.html depends on direction_delagate.html, which depends on
i18n_setup.html, which loads loadTimeData. So I had to remove this line
otherwise I get the following error

Unexpected condition on
chrome://md-settings/passwords_and_forms_page/autofill_section.html: should only
include this file once.

+  ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js',
 ]);
 
 /**
  * Test implementation.
  * @implements {settings.address.CountryDetailManager}
  * @constructor
  */
 function CountryDetailManagerTestImpl() {}
 CountryDetailManagerTestImpl.prototype = {
   /** @override */
   getCountryList: function() {
     return new Promise(function(resolve) {
       resolve([
-          {name: 'United States', countryCode: 'US'},  // Default test country.
-          {name: 'Israel', countryCode: 'IL'},
-          {name: 'United Kingdom', countryCode: 'GB'},
+        {name: 'United States', countryCode: 'US'},  // Default test country.
+        {name: 'Israel', countryCode: 'IL'},
+        {name: 'United Kingdom', countryCode: 'GB'},
       ]);
     });
   },
 
   /** @override */
   getAddressFormat: function(countryCode) {
     return new Promise(function(resolve) {
       chrome.autofillPrivate.getAddressComponents(countryCode, resolve);
     });
   },
 };
 
 /**
  * Will call |loopBody| for each item in |items|. Will only move to the next
  * item after the promise from |loopBody| resolves.
  * @param {!Array<Object>} items
  * @param {!function(!Object):!Promise} loopBody
  * @return {!Promise}
  */
 function asyncForEach(items, loopBody) {
-  return new Promise(function(finish) {
+  return new Promise(function(resolve) {
     var index = 0;
 
     function loop() {
       var item = items[index++];
       if (item)
         loopBody(item).then(loop);
       else
-        finish();
+        resolve();
     };
 
     loop();
   });
 }
 
 /**
  * Resolves the promise after the element fires the expected event. Will add and
  * remove the listener so it is only triggered once. |causeEvent| is called
  * after adding a listener to make sure that the event is captured.
@@ skipping 46 matching lines @@
     editCreditCardTitle: 'edit-title',
   },
 
   /** @override */
   setUp: function() {
     PolymerTest.prototype.setUp.call(this);
 
     // Test is run on an individual element that won't have a page language.
     this.accessibilityAuditConfig.auditRulesToIgnore.push('humanLangMissing');
 
-    // Faking 'strings.js' for this test.
-    loadTimeData.data = this.i18nStrings;

[dpapad, 2016/10/18 00:16:50]

This line started causing me problems, because loadTimeData was already
populated at the time this was called, triggering the assertion at
https://cs.chromium.org/chromium/src/ui/webui/resources/js/load_time_data.js?....
I don't think this is needed at all though (tests pass even without it, since
those i18n strings are already in loadTimeData.

-
     settings.address.CountryDetailManagerImpl.instance_ =
         new CountryDetailManagerTestImpl();
   },
 
   /**
    * Creates the autofill section for the given lists.
    * @param {!Array<!chrome.passwordsPrivate.PasswordUiEntry>} passwordList
    * @param {!Array<!chrome.passwordsPrivate.ExceptionPair>} exceptionList
    * @return {!Object}
    * @private
@@ skipping 687 matching lines @@
           assertEquals(city, cols[0].value);
           assertEquals(state, cols[1].value);
           assertEquals(zip, cols[2].value);
         });
       });
     });
   });
 
   mocha.run();
 });