Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2428723002: (re-land in M54) Disallow file api access from processes that lack permission (Closed)

Created:
4 years, 2 months ago by ncarter (slow)
Modified:
4 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[re-land in M54] Disallow file api access from processes that lack permissions for the scheme of the origin. BUG=644966 Review-Url: https://codereview.chromium.org/2387173005 Cr-Commit-Position: refs/heads/master@{#423348} TBR=creis@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/browser/child_process_security_policy_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ncarter (slow)
Charlie, after discussing this I believe we should re-enable this on M54. I intentionally didn't ...
4 years, 2 months ago (2016-10-17 21:51:49 UTC) #3
Charlie Reis
LGTM. Please give bustamante@ a heads up before landing on the branch, just to be ...
4 years, 2 months ago (2016-10-17 22:15:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428723002/1
4 years, 2 months ago (2016-10-18 20:02:43 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 20:07:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698