Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2428643002:
sanitizers: set is_lsan=true if use_libfuzzer and is_asan are set (linux) (Closed)
|
Created:
4 years, 2 months ago by Oliver Chang Modified:
4 years, 2 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionsanitizers: set is_lsan=true if use_libfuzzer and is_asan are set (linux)
R=dpranke@chromium.org,aizatsky@chromium.org
Committed: https://crrev.com/2e706c839ca64d5e7a4c8a5b27d9ca099a75c048
Cr-Commit-Position: refs/heads/master@{#425719}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add is_linux check, since we may have Windows libfuzzer in the future. #Patch Set 3 : add comment #Messages
Total messages: 18 (10 generated)
The CQ bit was checked by ochang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal. this is probably a better fix than https://codereview.chromium.org/2424893002/
inferno@chromium.org changed reviewers: + inferno@chromium.org, kcc@chromium.org
https://codereview.chromium.org/2428643002/diff/1/build/config/sanitizers/san... File build/config/sanitizers/sanitizers.gni (right): https://codereview.chromium.org/2428643002/diff/1/build/config/sanitizers/san... build/config/sanitizers/sanitizers.gni:158: if (use_libfuzzer && is_asan) { Add is_linux. since in next few months, libfuzzer will be enabled on windows. and also, this will fail on mac. Also add a comment to tell why we do this.
The CQ bit was checked by ochang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2428643002/diff/1/build/config/sanitizers/san... File build/config/sanitizers/sanitizers.gni (right): https://codereview.chromium.org/2428643002/diff/1/build/config/sanitizers/san... build/config/sanitizers/sanitizers.gni:158: if (use_libfuzzer && is_asan) { On 2016/10/17 17:03:19, inferno wrote: > Add is_linux. since in next few months, libfuzzer will be enabled on windows. > and also, this will fail on mac. > > Also add a comment to tell why we do this. Done.
lgtm
Description was changed from ========== sanitizers: set is_lsan=true if use_libfuzzer and is_asan are set. R=dpranke@chromium.org,aizatsky@chromium.org ========== to ========== sanitizers: set is_lsan=true if use_libfuzzer and is_asan are set (linux) R=dpranke@chromium.org,aizatsky@chromium.org ==========
lgtm
The CQ bit was unchecked by ochang@chromium.org
The CQ bit was checked by ochang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== sanitizers: set is_lsan=true if use_libfuzzer and is_asan are set (linux) R=dpranke@chromium.org,aizatsky@chromium.org ========== to ========== sanitizers: set is_lsan=true if use_libfuzzer and is_asan are set (linux) R=dpranke@chromium.org,aizatsky@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== sanitizers: set is_lsan=true if use_libfuzzer and is_asan are set (linux) R=dpranke@chromium.org,aizatsky@chromium.org ========== to ========== sanitizers: set is_lsan=true if use_libfuzzer and is_asan are set (linux) R=dpranke@chromium.org,aizatsky@chromium.org Committed: https://crrev.com/2e706c839ca64d5e7a4c8a5b27d9ca099a75c048 Cr-Commit-Position: refs/heads/master@{#425719} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2e706c839ca64d5e7a4c8a5b27d9ca099a75c048 Cr-Commit-Position: refs/heads/master@{#425719} |
