Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: third_party/WebKit/Source/web/TextFinder.h

Issue 2428613002: Removed limitation on searching frames for the same string prefix.
Patch Set: Removed m_lastSearchString. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/TextFinder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/TextFinder.h
diff --git a/third_party/WebKit/Source/web/TextFinder.h b/third_party/WebKit/Source/web/TextFinder.h
index 6c04b1e98f1fd334c3cc3090178663b42bdc3ea9..0b6c75b60fa2b8d4680ec87fd4e4c7b99482a290 100644
--- a/third_party/WebKit/Source/web/TextFinder.h
+++ b/third_party/WebKit/Source/web/TextFinder.h
@@ -226,16 +226,8 @@ class WEB_EXPORT TextFinder final
// search; the new search should start from this position.
Member<Range> m_resumeScopingFromRange;
- // Keeps track of the last string this frame searched for. This is used for
- // short-circuiting searches in the following scenarios: When a frame has
- // been searched and returned 0 results, we don't need to search that frame
- // again if the user is just adding to the search (making it more specific).
- WTF::String m_lastSearchString;
-
// Keeps track of how many matches this frame has found so far, so that we
- // don't lose count between scoping efforts, and is also used (in conjunction
- // with m_lastSearchString) to figure out if we need to search the frame
- // again.
+ // don't lose count between scoping efforts.
int m_lastMatchCount;
// This variable keeps a cumulative total of matches found so far in this
@@ -276,10 +268,6 @@ class WEB_EXPORT TextFinder final
// Keeps track of whether there is an scoping effort ongoing in the frame.
bool m_scopingInProgress;
- // Keeps track of whether the last find request completed its scoping effort
- // without finding any matches in this frame.
- bool m_lastFindRequestCompletedWithNoMatches;
-
// Determines if the rects in the find-in-page matches cache of this frame
// are invalid and should be recomputed.
bool m_findMatchRectsAreValid;
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/TextFinder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698