Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2428583002: [wasm] Break effect cycles in the Int64Lowering. (Closed)

Created:
4 years, 2 months ago by ahaas
Modified:
4 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Break effect cycles in the Int64Lowering. EffectPhis can cause a cycle in a TurboFan graph. We delay the processing of EffectPhis in the Int64Lowering to break these cycles. We do the same already for Phis. R=titzer@chromium.org BUG=v8:5518 TEST=unittests/Int64LoweringTest.EffectPhiLoop Committed: https://crrev.com/34fa66c08c2cbd62907d9f306709e8f9732c6a65 Cr-Commit-Position: refs/heads/master@{#40378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M src/compiler/int64-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 2 months ago (2016-10-17 14:37:15 UTC) #1
titzer
On 2016/10/17 14:37:15, ahaas wrote: lgtm
4 years, 2 months ago (2016-10-17 14:40:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428583002/1
4 years, 2 months ago (2016-10-18 06:27:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 06:30:46 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 06:31:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34fa66c08c2cbd62907d9f306709e8f9732c6a65
Cr-Commit-Position: refs/heads/master@{#40378}

Powered by Google App Engine
This is Rietveld 408576698